Details

Reviewers

deadalnix
jasonbcox
Fabien

Group Reviewers

Restricted Project

Maniphest Tasks

T630: Backport PR 13243 "Make reusable base class for auxiliary indices"

Commits

rSTAGINGc3448655ec34: Merge #14085: index: Fix for indexers skipping genesis block.
rABCc3448655ec34: Merge #14085: index: Fix for indexers skipping genesis block.

Summary

PR14085 backport https://github.com/bitcoin/bitcoin/pull/14085/files
ed12d5df1ba52b5ef3dd3799de26bb5e1d3fc654 index: Fix for indexers skipping genesis block. (Jim Posen)

Pull request description:

This fixes a bug where indexers would skip processing of the genesis block. Preserves the current behavior of omitting genesis block transaction from the index.

Backporter note: indeed this changes nothing about current behaviour, it
just prepares for BIP157 filters that want to index the genesis.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

arcpatch-D3310

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6328
Build 10703: Bitcoin ABC Buildbot (legacy)
Build 10702: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 13 2019, 02:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 02:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T630: Backport PR 13243 "Make reusable base class for auxiliary indices".Jun 13 2019, 02:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6299: Diff 9373.Jun 13 2019, 02:14

Fabien requested changes to this revision.Jun 13 2019, 06:14

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/index/txindex.cpp
250 ↗	(On Diff #9373)	Braces
src/test/txindex_tests.cpp
6 ↗	(On Diff #9373)	Keep first on first place (on its own line to avoid the linter to reorder).
8 ↗	(On Diff #9373)	While you're at it, can you move this below this section ?