Page MenuHomePhabricator
Differential D3336

tests: Avoid copies of CTransaction
ClosedPublic
Actions

Authored by deadalnix on Jun 14 2019, 16:28.

Details

Reviewers
Fabien
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING0d8923573d99: tests: Avoid copies of CTransaction
rABC0d8923573d99: tests: Avoid copies of CTransaction
Summary

This is a backport of what remains of Core PR12949.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
notxcopy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6345
Build 10737: Bitcoin ABC Buildbot (legacy)
Build 10736: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 14 2019, 16:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2019, 16:28
teamcity added a comment.Jun 14 2019, 16:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 14 2019, 16:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6345: Diff 9447.Jun 14 2019, 16:37
deadalnix added a child revision: D3343: [refactor] Make TransactionWithinChainLimit more flexible.Jun 14 2019, 21:26
jasonbcox added a subscriber: jasonbcox.Jun 14 2019, 22:12
jasonbcox added inline comments.
src/test/blockencodings_tests.cpp
251

comment says +2 but it's +3

src/wallet/test/wallet_tests.cpp
177

This isn't part of the original PR. Unless it gets rid of some warnings or something useful, I don't see it belonging in this diff.

Fabien requested changes to this revision.Jun 17 2019, 07:18
Fabien added a subscriber: Fabien.

See Jason's comments, clearing my queue.

This revision now requires changes to proceed.Jun 17 2019, 07:18
deadalnix added inline comments.Jun 17 2019, 16:31
src/wallet/test/wallet_tests.cpp
177

signed vs unsigned compare.

deadalnix updated this revision to Diff 9496.Jun 17 2019, 17:12

Fix mempool_tests.cpp , Fix comment saying +2 when +3 is relevent.

teamcity added a comment.Jun 17 2019, 17:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 17 2019, 17:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6380: Diff 9496.Jun 17 2019, 17:20
jasonbcox accepted this revision.Jun 17 2019, 17:33
jasonbcox added inline comments.
src/wallet/test/wallet_tests.cpp
177

Yes, but please check that there isn't a missing backport here.

Fabien accepted this revision.Jun 18 2019, 06:02
This revision is now accepted and ready to land.Jun 18 2019, 06:02
Closed by commit rABC0d8923573d99: tests: Avoid copies of CTransaction (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyJun 18 2019, 11:55
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC0d8923573d99: tests: Avoid copies of CTransaction.
deadalnix added a commit: rSTAGING0d8923573d99: tests: Avoid copies of CTransaction.Sep 19 2019, 00:23

Revision Contents
Changeset List

PathSize
src/
test/
39 lines
3 lines
12 lines
wallet/
test/
4 lines

Diff 9447

View Options

src/test/blockencodings_tests.cpp

Loading...
View Options

src/test/test_bitcoin.h

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...