Page MenuHomePhabricator

tests: Avoid copies of CTransaction
ClosedPublic

Authored by deadalnix on Jun 14 2019, 16:28.

Details

Summary

This is a backport of what remains of Core PR12949.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
notxcopy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6380
Build 10807: Bitcoin ABC Buildbot (legacy)
Build 10806: arc lint + arc unit

Event Timeline

jasonbcox added inline comments.
src/test/blockencodings_tests.cpp
251 ↗(On Diff #9447)

comment says +2 but it's +3

src/wallet/test/wallet_tests.cpp
177 ↗(On Diff #9447)

This isn't part of the original PR. Unless it gets rid of some warnings or something useful, I don't see it belonging in this diff.

Fabien requested changes to this revision.Jun 17 2019, 07:18
Fabien added a subscriber: Fabien.

See Jason's comments, clearing my queue.

This revision now requires changes to proceed.Jun 17 2019, 07:18
src/wallet/test/wallet_tests.cpp
177 ↗(On Diff #9447)

signed vs unsigned compare.

Fix mempool_tests.cpp , Fix comment saying +2 when +3 is relevent.

jasonbcox added inline comments.
src/wallet/test/wallet_tests.cpp
177 ↗(On Diff #9447)

Yes, but please check that there isn't a missing backport here.

This revision is now accepted and ready to land.Jun 18 2019, 06:02
This revision was automatically updated to reflect the committed changes.