Differential D3336

tests: Avoid copies of CTransaction
ClosedPublic
Actions

Authored by deadalnix on Jun 14 2019, 16:28.

Tags

None

Subscribers

Details

Reviewers

Fabien
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING0d8923573d99: tests: Avoid copies of CTransaction
rABC0d8923573d99: tests: Avoid copies of CTransaction

Summary

This is a backport of what remains of Core PR12949.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

notxcopy

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6380
Build 10807: Bitcoin ABC Buildbot (legacy)
Build 10806: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 14 2019, 16:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2019, 16:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6345: Diff 9447.Jun 14 2019, 16:37

deadalnix added a child revision: D3343: [refactor] Make TransactionWithinChainLimit more flexible.Jun 14 2019, 21:26

jasonbcox added a subscriber: jasonbcox.Jun 14 2019, 22:12

jasonbcox added inline comments.

src/test/blockencodings_tests.cpp
251 ↗	(On Diff #9447)	comment says +2 but it's +3
src/wallet/test/wallet_tests.cpp
177 ↗	(On Diff #9447)	This isn't part of the original PR. Unless it gets rid of some warnings or something useful, I don't see it belonging in this diff.

See Jason's comments, clearing my queue.

This revision now requires changes to proceed.Jun 17 2019, 07:18

deadalnix added inline comments.Jun 17 2019, 16:31

src/wallet/test/wallet_tests.cpp
177 ↗	(On Diff #9447)	signed vs unsigned compare.

Fix mempool_tests.cpp , Fix comment saying +2 when +3 is relevent.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6380: Diff 9496.Jun 17 2019, 17:20

jasonbcox accepted this revision.Jun 17 2019, 17:33

jasonbcox added inline comments.

src/wallet/test/wallet_tests.cpp
177 ↗	(On Diff #9447)	Yes, but please check that there isn't a missing backport here.

Fabien accepted this revision.Jun 18 2019, 06:02

This revision is now accepted and ready to land.Jun 18 2019, 06:02

Closed by commit rABC0d8923573d99: tests: Avoid copies of CTransaction (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyJun 18 2019, 11:55

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC0d8923573d99: tests: Avoid copies of CTransaction.

deadalnix added a commit: rSTAGING0d8923573d99: tests: Avoid copies of CTransaction.Sep 19 2019, 00:23

Revision Contents
Changeset List

Path

Size

src/

test/

blockencodings_tests.cpp

39 lines

mempool_tests.cpp

9 lines

3 lines

test_bitcoin.cpp

12 lines

wallet/

test/

wallet_tests.cpp

4 lines

Diff 9496

src/test/blockencodings_tests.cpp

Loading...

src/test/mempool_tests.cpp

Loading...

src/test/test_bitcoin.h

Loading...

src/test/test_bitcoin.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...