Page MenuHomePhabricator
Differential D3385

Merge #10380: [doc] Removing comments about dirty entries on txmempool
ClosedPublic
Actions

Authored by nakihito on Jun 21 2019, 22:46.

Details

Reviewers
deadalnix
Fabien
jasonbcox
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING7a5d17fd0fe0: Merge #10380: [doc] Removing comments about dirty entries on txmempool
rABC7a5d17fd0fe0: Merge #10380: [doc] Removing comments about dirty entries on txmempool
Summary

4f3782e [doc] Removing comments about dirty entries on txmempool (Simone Madeo)

Tree-SHA512: 12ffad7237e2a8ec658cfcff263dad5a2220beadda48d67095df90c2f8ea55ffb6891d919698893b625965fb3069a05e7901fac6cceb3d1228e6833356408074

Backport of Core PR10380
https://github.com/bitcoin/bitcoin/pull/10380/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10380
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6439
Build 10925: Bitcoin ABC Buildbot (legacy)
Build 10924: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 21 2019, 22:46
Owners added a reviewer: Restricted Owners Package.Jun 21 2019, 22:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 21 2019, 22:46
teamcity added a comment.Jun 21 2019, 22:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 21 2019, 22:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6437: Diff 9579.Jun 21 2019, 22:56
jasonbcox requested changes to this revision.Jun 21 2019, 22:56
jasonbcox added inline comments.
src/txmempool.h
107 ↗(On Diff #9579)

Fix weird duplicate double slash

This revision now requires changes to proceed.Jun 21 2019, 22:56
nakihito updated this revision to Diff 9581.Jun 21 2019, 23:10

Fixed duplicate //.

teamcity added a comment.Jun 21 2019, 23:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito updated this revision to Diff 9582.Jun 21 2019, 23:12

Fixed spacing.

teamcity added a comment.Jun 21 2019, 23:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 21 2019, 23:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6439: Diff 9581.Jun 21 2019, 23:16
teamcity added a comment.Jun 21 2019, 23:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6440: Diff 9582.Jun 21 2019, 23:22
deadalnix accepted this revision.Jun 22 2019, 02:05
Fabien accepted this revision.Jun 24 2019, 10:03
jasonbcox accepted this revision.Jun 24 2019, 16:11
This revision is now accepted and ready to land.Jun 24 2019, 16:11
Closed by commit rABC7a5d17fd0fe0: Merge #10380: [doc] Removing comments about dirty entries on txmempool (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyJun 24 2019, 17:48
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC7a5d17fd0fe0: Merge #10380: [doc] Removing comments about dirty entries on txmempool.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING7a5d17fd0fe0: Merge #10380: [doc] Removing comments about dirty entries on txmempool.Sep 19 2019, 00:29

Revision Contents
Changeset List

PathSize
src/
22 lines

Diff 9581

View Options

src/txmempool.h

Loading...