Page MenuHomePhabricator
Differential D3435

Do not unlock cs_main in ABC unless we've actually made progress.
ClosedPublic
Actions

Authored by deadalnix on Jun 27 2019, 16:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING461bec4096a5: Do not unlock cs_main in ABC unless we've actually made progress.
rABC461bec4096a5: Do not unlock cs_main in ABC unless we've actually made progress.
Summary

Technically, some internal datastructures may be in an inconsistent
state if we do this, though there are no known bugs there. Still,
for future safety, its much better to only unlock cs_main if we've
made progress (not just tried a reorg which may make progress).

This is extracted from Core PR13023 : https://github.com/bitcoin/bitcoin/pull/13023/commits/ecc3c4a019e6db30e208b8554b1a3658dcb9a80a

Test Plan
make check

Diff Detail

Event Timeline

deadalnix created this revision.Jun 27 2019, 16:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2019, 16:38
teamcity added a comment.Jun 27 2019, 16:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D3436: Fix concurrency-related bugs in ActivateBestChain.Jun 27 2019, 16:42
Harbormaster completed remote builds in B6507: Diff 9717.Jun 27 2019, 16:45
teamcity added a comment.Jun 27 2019, 16:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Jun 28 2019, 13:59
This revision is now accepted and ready to land.Jun 28 2019, 13:59
Closed by commit rABC461bec4096a5: Do not unlock cs_main in ABC unless we've actually made progress. (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyJun 28 2019, 14:06
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC461bec4096a5: Do not unlock cs_main in ABC unless we've actually made progress..
markblundeberg mentioned this in D3638: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.Jul 10 2019, 18:12
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC8b410f1118ea: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.Jul 13 2019, 01:05
deadalnix added a commit: rSTAGING461bec4096a5: Do not unlock cs_main in ABC unless we've actually made progress..Sep 19 2019, 00:42
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING8b410f1118ea: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.Sep 19 2019, 01:14

Revision Contents
Changeset List

PathSize
src/
107 lines
6 lines

Diff 9717

View Options

src/validation.cpp

Loading...
View Options

src/validationinterface.h

Loading...