[ibd.sh] Store datadir and debug.log paths in variables
ClosedPublic
Actions

Authored by jasonbcox on Jun 28 2019, 00:18.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING8031a511b94c: [ibd.sh] Store datadir and debug.log paths in variables
rABC8031a511b94c: [ibd.sh] Store datadir and debug.log paths in variables

Summary

This makes it easy to change the location of the datadir or debug.log without updating it in a bunch of places and risking
the chance of forgetting or typos.

Test Plan

IBD on TeamCity via D3453

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ibd-debug-log

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6539
Build 11125: Bitcoin ABC Buildbot (legacy)
Build 11124: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 28 2019, 00:18

Herald added a reviewer: deadalnix. · View Herald TranscriptJun 28 2019, 00:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox planned changes to this revision.Jun 28 2019, 00:19

jasonbcox edited the test plan for this revision. (Show Details)Jun 28 2019, 00:23

jasonbcox added a child revision: D3453: [ibd.sh] Add chainwork sanity check.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6525: Diff 9746.Jun 28 2019, 00:28

Added DATA_DIR

jasonbcox planned changes to this revision.Jun 28 2019, 16:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox retitled this revision from [ibd.sh] Store debug.log location in a variable to [ibd.sh] Store datadir and debug.log paths in variables.Jun 28 2019, 16:05

jasonbcox edited the summary of this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6539: Diff 9773.Jun 28 2019, 16:14

jasonbcox requested review of this revision.Jun 29 2019, 15:30

deadalnix requested changes to this revision.Jun 30 2019, 00:45

deadalnix added inline comments.