Hardcoded seeds update
AbandonedPublic
Actions

Authored by sickpig on Jul 31 2017, 13:09.

Details

Reviewers

freetrader
deadalnix
kyuupichan
awemany

Group Reviewers

Restricted Project

Summary

Starting from the data fetched by the seeder's crawlers
this commit will add a list of know and working BCC compliant
nodes to src/chainparamsseeds.h.

The process to follow to update the file is the following

curl -Ls https://gist.githubusercontent.com/sickpig/2c98c30ca96f19c617328bb87c00e7c0/raw/51b697c408167aba182173bf5448c7c8c5e0403e/seeds_bcc_main.txt > seeds_bcc_main.txt
python3 ./contrib/seeds/makeseeds.py < seeds_bcc_main.txt > nodes_main.txt
touch node_tests.txt
python3 ./contrib/seeds/generate-seeds.py . > src/chainparamsseeds.h

the data fetched from the git gist is a dump of the internal list of
nodes stored by the btccash-seeder.bitcoinunlimited.info.

In the process contrib/seeds/makeseeds.py has been adapted to
handle the BCC implementations useragent (BUcash, XT, ABC and Classic)
and a bunch of filters rules has been relaxed due to the fact we
are still in the bootstrap step.

Test Plan

reproduce the change to src/chainparamsseeds.h using the step above

Diff Detail

Repository

rABC Bitcoin ABC

Branch

update-hardcoded-seeds

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 623
Build 623: arc lint + arc unit

Event Timeline

sickpig created this revision.Jul 31 2017, 13:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2017, 13:09

Exclude src/chainparamsseeds.h from formatting and autopep8 contrib/seeds/makeseeds.py in another diff then rebase.

This revision now requires changes to proceed.Jul 31 2017, 13:17

Harbormaster completed remote builds in B619: Diff 990.Jul 31 2017, 13:23

makeseeds.py has already been linted using autopep8.

Going to exclude from the linting chainparamsseeds.h process and I will update the diff

Exclude src/chainparamsseeds.h from linting process

Harbormaster completed remote builds in B621: Diff 992.Jul 31 2017, 14:06

autopep8

This revision now requires changes to proceed.Jul 31 2017, 14:33

misunderstood what you meant.
going to exclude contrib/seeds/makeseeds.py from linting

Exclude contrib/seeds/makeseeds.py from the linting process

No. It's not what I asked.

This revision now requires changes to proceed.Jul 31 2017, 15:42

what you asked then?

to lint makeseeds.py using autopep8? cause if it is the case this what I did in the first place.

Otherwise please state explicitly what you want.

In D399#6760, @deadalnix wrote:

Exclude src/chainparamsseeds.h from formatting and autopep8 contrib/seeds/makeseeds.py in another diff then rebase.

Format makeseeds.py using autopep8 (like it was in the 1st submission)

Harbormaster completed remote builds in B623: Diff 994.Jul 31 2017, 16:52

In D399#6798, @deadalnix wrote:

In D399#6760, @deadalnix wrote:

Exclude src/chainparamsseeds.h from formatting and autopep8 contrib/seeds/makeseeds.py *in another diff then rebase*.

This revision now requires changes to proceed.Jul 31 2017, 17:00

ok got what you meant hopefully.
In https://reviews.bitcoinabc.org/D401 I've excluded src/chainparamsseeds.h from being ling and autopep8 contrib/seeds/makeseeds.py
once it's landed I'm going to rebase D399