Page MenuHomePhabricator
Differential D3553

rpcuser.py: Use 'python' not 'python2'
ClosedPublic
Actions

Authored by Fabien on Jul 5 2019, 07:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING1f84e1edb9e5: rpcuser.py: Use 'python' not 'python2'
rABC1f84e1edb9e5: rpcuser.py: Use 'python' not 'python2'
Summary
Note that rpcuser.py seems to handle either version when called
explicitly like python2 rpcuser.py / python3 rpcuser.py. This change
allows the user's python to be used to interpret the script.

Backport of core PR11830
https://github.com/bitcoin/bitcoin/pull/11830/files

Test Plan
python2 share/rpcuser/rpcuser.py foo
python3 share/rpcuser/rpcuser.py foo

Should return the rpcauth string without error

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11830
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6671
Build 11389: Bitcoin ABC Buildbot (legacy)
Build 11388: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 5 2019, 07:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 07:45
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 5 2019, 07:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 5 2019, 07:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6671: Diff 9987.Jul 5 2019, 07:51
Fabien added a child revision: D3555: Rename rpcuser.py to rpcauth.py.Jul 5 2019, 08:28
deadalnix accepted this revision.Jul 5 2019, 13:49
This revision is now accepted and ready to land.Jul 5 2019, 13:49
Fabien edited the summary of this revision. (Show Details)Jul 5 2019, 14:41
Closed by commit rABC1f84e1edb9e5: rpcuser.py: Use 'python' not 'python2' (authored by Henrik Jonsson <me@hkjn.me>, committed by Fabien). · Explain WhyJul 5 2019, 14:41
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC1f84e1edb9e5: rpcuser.py: Use 'python' not 'python2'.
Fabien added a commit: rSTAGING1f84e1edb9e5: rpcuser.py: Use 'python' not 'python2'.Sep 19 2019, 00:58

Revision Contents
Changeset List

PathSize
share/
rpcuser/
2 lines

Diff 9987

View Options

share/rpcuser/rpcuser.py

Loading...