Page MenuHomePhabricator

Add share/rpcuser to dist. source code archive
ClosedPublic

Authored by Fabien on Jul 5 2019, 08:24.

Details

Summary
As the legacy rpcuser and rpcpassword are deprected since 0.12.0, we
should actually include the script to generate the new auth pair in the
distributed source code archive.

Backport of core PR11530
https://github.com/bitcoin/bitcoin/pull/11530/files

Test Plan
make dist

Check the script is part of the generated archive

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jul 5 2019, 08:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 08:24
deadalnix requested changes to this revision.Jul 5 2019, 13:54

This should have a cmake equivalent.

This revision now requires changes to proceed.Jul 5 2019, 13:54
Fabien requested review of this revision.Jul 5 2019, 14:23

My plan is to sync autotools with core before adding the remaining missing features to CMake, as there is little left to backport.
ATM there is no equivalent to the make dist target with our CMake code.

deadalnix accepted this revision.Jul 6 2019, 15:13
This revision is now accepted and ready to land.Jul 6 2019, 15:13
This revision was automatically updated to reflect the committed changes.