Add share/rpcuser to dist. source code archive
ClosedPublic
Actions

Authored by Fabien on Jul 5 2019, 08:24.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGcf7e92c77816: Add share/rpcuser to dist. source code archive
rABCcf7e92c77816: Add share/rpcuser to dist. source code archive

Summary

As the legacy rpcuser and rpcpassword are deprected since 0.12.0, we
should actually include the script to generate the new auth pair in the
distributed source code archive.

Backport of core PR11530
https://github.com/bitcoin/bitcoin/pull/11530/files

Test Plan

make dist

Check the script is part of the generated archive

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11530

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6672
Build 11391: Bitcoin ABC Buildbot (legacy)
Build 11390: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 5 2019, 08:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 08:24

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D3555: Rename rpcuser.py to rpcauth.py.Jul 5 2019, 08:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6672: Diff 9988.Jul 5 2019, 08:31

This should have a cmake equivalent.

This revision now requires changes to proceed.Jul 5 2019, 13:54

My plan is to sync autotools with core before adding the remaining missing features to CMake, as there is little left to backport.
ATM there is no equivalent to the make dist target with our CMake code.

deadalnix accepted this revision.Jul 6 2019, 15:13

This revision is now accepted and ready to land.Jul 6 2019, 15:13

Closed by commit rABCcf7e92c77816: Add share/rpcuser to dist. source code archive (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJul 7 2019, 10:58

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCcf7e92c77816: Add share/rpcuser to dist. source code archive.

Fabien mentioned this in D3555: Rename rpcuser.py to rpcauth.py.Jul 7 2019, 11:03

Fabien added a commit: rSTAGINGcf7e92c77816: Add share/rpcuser to dist. source code archive.Sep 19 2019, 01:01