Page MenuHomePhabricator
Differential D3557

tests: Remove compatibility code not needed now when we're on Python 3
ClosedPublic
Actions

Authored by Fabien on Jul 5 2019, 09:43.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING93cf4a745237: tests: Remove compatibility code not needed now when we're on Python 3
rABC93cf4a745237: tests: Remove compatibility code not needed now when we're on Python 3
Summary
Remove compatibility code not needed now when we're on Python 3.

Backport of core PR12993
https://github.com/bitcoin/bitcoin/pull/12993/files

Depends on D3556

Test Plan
./test/functional/test_runner.py
../share/rpcauth/rpcauth.py foo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 5 2019, 09:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 09:43
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 5 2019, 09:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 5 2019, 09:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6675: Diff 9991.Jul 5 2019, 09:49
deadalnix requested changes to this revision.Jul 5 2019, 13:49

This patch depend on itself...

This revision now requires changes to proceed.Jul 5 2019, 13:49
Fabien edited the summary of this revision. (Show Details)Jul 5 2019, 14:06
Fabien added a parent revision: D3556: Change all python files to use Python3.
Fabien requested review of this revision.Jul 5 2019, 14:08

Oups !

deadalnix accepted this revision.Jul 5 2019, 14:20
This revision is now accepted and ready to land.Jul 5 2019, 14:20
Closed by commit rABC93cf4a745237: tests: Remove compatibility code not needed now when we're on Python 3 (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJul 8 2019, 10:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC93cf4a745237: tests: Remove compatibility code not needed now when we're on Python 3.
Fabien added a commit: rSTAGING93cf4a745237: tests: Remove compatibility code not needed now when we're on Python 3.Sep 19 2019, 01:01

Revision Contents
Changeset List

PathSize
share/
rpcauth/
13 lines
test/
functional/
test_framework/
8 lines
36 lines

Diff 10077

View Options

share/rpcauth/rpcauth.py

Loading...
View Options

test/functional/test_framework/key.py

Loading...
View Options

test/functional/test_framework/script.py

Loading...