Page MenuHomePhabricator

Rename rpcuser.py to rpcauth.py
ClosedPublic

Authored by Fabien on Jul 5 2019, 08:28.

Details

Summary
This script creates `rpcauth` entries for bitcoin.conf,
not the deprecated `rpcuser` entry, so this changes the name
of the script to match.

Backport of core PR11836
https://github.com/bitcoin/bitcoin/pull/11836/files

Depends on D3553 and D3554

Test Plan
./share/rpcauth/rpcauth.py foo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jul 5 2019, 08:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 08:28
deadalnix requested changes to this revision.Jul 5 2019, 13:53
deadalnix added inline comments.
Makefile.am
52 ↗(On Diff #9989)

Presumably, this has an equivalent in cmake?

This revision now requires changes to proceed.Jul 5 2019, 13:53
Fabien requested review of this revision.Jul 7 2019, 11:03

Same as D3554:
My plan is to sync autotools with core before adding the remaining missing features to CMake, as there is little left to backport.
ATM there is no equivalent to the make dist target with our CMake code.

deadalnix accepted this revision.Jul 7 2019, 14:47
This revision is now accepted and ready to land.Jul 7 2019, 14:47
This revision was automatically updated to reflect the committed changes.