Page MenuHomePhabricator
Differential D3555

Rename rpcuser.py to rpcauth.py
ClosedPublic
Actions

Authored by Fabien on Jul 5 2019, 08:28.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING478709f20ec8: Rename rpcuser.py to rpcauth.py
rABC478709f20ec8: Rename rpcuser.py to rpcauth.py
Summary
This script creates `rpcauth` entries for bitcoin.conf,
not the deprecated `rpcuser` entry, so this changes the name
of the script to match.

Backport of core PR11836
https://github.com/bitcoin/bitcoin/pull/11836/files

Depends on D3553 and D3554

Test Plan
./share/rpcauth/rpcauth.py foo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 5 2019, 08:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 08:28
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 5 2019, 08:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 5 2019, 08:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6673: Diff 9989.Jul 5 2019, 08:39
Fabien added a child revision: D3556: Change all python files to use Python3.Jul 5 2019, 09:21
deadalnix requested changes to this revision.Jul 5 2019, 13:53
deadalnix added inline comments.
Makefile.am
52 ↗(On Diff #9989)

Presumably, this has an equivalent in cmake?

This revision now requires changes to proceed.Jul 5 2019, 13:53
Fabien requested review of this revision.Jul 7 2019, 11:03

Same as D3554:
My plan is to sync autotools with core before adding the remaining missing features to CMake, as there is little left to backport.
ATM there is no equivalent to the make dist target with our CMake code.

deadalnix accepted this revision.Jul 7 2019, 14:47
This revision is now accepted and ready to land.Jul 7 2019, 14:47
Closed by commit rABC478709f20ec8: Rename rpcuser.py to rpcauth.py (authored by Henrik Jonsson <me@hkjn.me>, committed by Fabien). · Explain WhyJul 8 2019, 10:25
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC478709f20ec8: Rename rpcuser.py to rpcauth.py.
Fabien added a commit: rSTAGING478709f20ec8: Rename rpcuser.py to rpcauth.py.Sep 19 2019, 01:01

Revision Contents
Changeset List

PathSize
2 lines
contrib/
debian/
examples/
4 lines
doc/
6 lines
share/
rpcauth/
10 lines
rpcauth/
rpcuser/
rpcauth.py
rpcuser.py
rpcuser/

Diff 10075

View Options

Makefile.am

Loading...
View Options

contrib/debian/examples/bitcoin.conf

Loading...
View Options

doc/release-notes.md

Loading...
View Options

share/rpcauth/README.md

Loading...
View Options

share/rpcauth/rpcauth.py

Loading...
View Options

share/rpcuser/README.md

Loading...
View Options

share/rpcuser/rpcuser.py

Loading...