[tests] fix flake8 nits in feature_csv_activation.py
ClosedPublic
Actions

Authored by Fabien on Jul 5 2019, 12:37.

Details

Reviewers

deadalnix
markblundeberg

Group Reviewers

Restricted Project

Maniphest Tasks

T669: Removing comparison test framework

Commits

rSTAGINGa3ec7ccdd58f: [tests] fix flake8 nits in feature_csv_activation.py
rABCa3ec7ccdd58f: [tests] fix flake8 nits in feature_csv_activation.py

Summary

Partial backport of core PR11817 (commit 6f7f5bc)
https://github.com/bitcoin/bitcoin/pull/11817/commits/6f7f5bc0026df12b64935b4e9db32cfc7b6e8829

Depends on D3561

Very few changes remain from this commit due to previous refactoring and
linter actions.
Because a lot of changes are erased by later commits, I backported it
last (it is the first commit in core PR) so that it is easier to review.

Test Plan

./test/functional/test_runner.py feature_csv_activation

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11817_part5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6681
Build 11409: Bitcoin ABC Buildbot (legacy)
Build 11408: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 5 2019, 12:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 12:37

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6681: Diff 9997.Jul 5 2019, 12:43

markblundeberg added a task: T669: Removing comparison test framework.Jul 5 2019, 12:57

markblundeberg accepted this revision.Jul 5 2019, 13:25

This revision is now accepted and ready to land.Jul 5 2019, 13:25

Closed by commit rABCa3ec7ccdd58f: [tests] fix flake8 nits in feature_csv_activation.py (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJul 5 2019, 13:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa3ec7ccdd58f: [tests] fix flake8 nits in feature_csv_activation.py.

Fabien added a commit: rSTAGINGa3ec7ccdd58f: [tests] fix flake8 nits in feature_csv_activation.py.Sep 19 2019, 00:57

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_csv_activation.py

11 lines

Diff 9997

View Options

test/functional/feature_csv_activation.py

[tests] fix flake8 nits in feature_csv_activation.pyClosedPublicActions