Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jan 19 2018

matiu closed D979: Make forknotify.py more robust.
Jan 19 2018, 15:58
matiu committed rABC480e057fe351: Wait for connection to open in bip9-softforks.py (authored by John Newbery <john@johnnewbery.com>).
Wait for connection to open in bip9-softforks.py
Jan 19 2018, 15:57
matiu closed D972: Wait for connection to open in bip9-softforks.py.
Jan 19 2018, 15:57
matiu accepted D980: Start a guide regarding how to backport code to Bitcoin-ABC.

Added some minor comments. Great work.... thanks, this will help a lot.

Jan 19 2018, 04:29
matiu added a comment to D980: Start a guide regarding how to backport code to Bitcoin-ABC.

Nice ! Thanks for putting this together.

Jan 19 2018, 04:26

Jan 18 2018

matiu added a comment to T163: test_runner.py should not list all the test, but instead be able to find them..

ok, what about we have 3 paths:

Jan 18 2018, 17:39 · Bootcamp
matiu updated the diff for D979: Make forknotify.py more robust.

update diff with missing changes.

Jan 18 2018, 16:23
matiu added a comment to T145: Port core PR10072.

This is a dup of T144 and it is fixed at D979

Jan 18 2018, 04:07 · Bootcamp
matiu updated the summary of D979: Make forknotify.py more robust.
Jan 18 2018, 04:07
matiu added a task to D979: Make forknotify.py more robust: T144: Backport for PR 10072: Remove sources of unreliablility in extended functional tests.
Jan 18 2018, 03:56
matiu added a revision to T144: Backport for PR 10072: Remove sources of unreliablility in extended functional tests: D979: Make forknotify.py more robust.
Jan 18 2018, 03:56
Herald added a reviewer for D979: Make forknotify.py more robust: Restricted Project.
Jan 18 2018, 03:54
matiu added a comment to T163: test_runner.py should not list all the test, but instead be able to find them..

Tests are ordered by the estimated runtime, to favor running tests in parallel (at BASE_SCRIPTS and EXTENDED_SCRIPTS arrays).

Jan 18 2018, 03:28 · Bootcamp

Jan 17 2018

matiu added a comment to D972: Wait for connection to open in bip9-softforks.py.

Tests seem to be passing with the latest update (Diff id 2568):

Jan 17 2018, 22:14
matiu updated the diff for D972: Wait for connection to open in bip9-softforks.py.
Jan 17 2018, 20:04
matiu updated the diff for D972: Wait for connection to open in bip9-softforks.py.

Adds changes in D969 to fix tests. Please note what with this changes, config.ini in zmq_test and test_runner match the ones at https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_runner.py#L204

Jan 17 2018, 19:33
matiu added a comment to D972: Wait for connection to open in bip9-softforks.py.
In D972#17470, @deadalnix wrote:

That was on my TODO list, but it seems like the build is failing. Can you make sure it passes, maybe rebase and update the diff ?

Jan 17 2018, 17:19
matiu updated the diff for D972: Wait for connection to open in bip9-softforks.py.

Rebased to current master.

Jan 17 2018, 17:05
Herald added a reviewer for D972: Wait for connection to open in bip9-softforks.py: Restricted Project.
Jan 17 2018, 15:51
matiu abandoned D969: backport b8251f63373ed58a05d104f9c1637d2c07b3569e.
Jan 17 2018, 01:39
matiu added a comment to D969: backport b8251f63373ed58a05d104f9c1637d2c07b3569e.

got it, thanks for the explanation.

Jan 17 2018, 01:38
matiu updated the summary of D969: backport b8251f63373ed58a05d104f9c1637d2c07b3569e.
Jan 17 2018, 00:59
matiu updated the summary of D969: backport b8251f63373ed58a05d104f9c1637d2c07b3569e.
Jan 17 2018, 00:56
matiu added a comment to D969: backport b8251f63373ed58a05d104f9c1637d2c07b3569e.

Fixes https://reviews.bitcoinabc.org/T148

Jan 17 2018, 00:48
matiu added a comment to T148: Support out of tree builds in zmq tests.
Jan 17 2018, 00:48
Herald added a reviewer for D969: backport b8251f63373ed58a05d104f9c1637d2c07b3569e: Restricted Project.
Jan 17 2018, 00:46

Jan 16 2018

matiu added a comment to T114: Build broken on MacOS X.

Is this fixed already? I built in macos the current master (88232d52a91478c9cc765ea6de0bc4ac44c35ede) and built on osx 10.13.2 without problems.

Jan 16 2018, 19:00
First
Prev