Page MenuHomePhabricator
Feed Advanced Search

Jul 31 2024

Fabien requested review of D16563: build: fix mingw miniupnpc cflags.
Jul 31 2024, 18:56
teamcity awarded D16562: build: miniupnpc 2.2.2 a Haypence token.
Jul 31 2024, 18:48
Fabien added a comment to D16562: build: miniupnpc 2.2.2.

@bot guix-linux guix-osx guix-win

Jul 31 2024, 18:48
Fabien requested review of D16562: build: miniupnpc 2.2.2.
Jul 31 2024, 18:48
Fabien requested review of D16561: Extract tx pool outside of txorphanage.
Jul 31 2024, 16:20
Fabien accepted D16526: [chronik] add a block-headers endpoint.
Jul 31 2024, 13:49
Fabien closed D16539: Get rid of ConnectTrace.
Jul 31 2024, 06:11
Fabien committed rABC12f60ab72be7: Get rid of ConnectTrace (authored by Fabien).
Get rid of ConnectTrace
Jul 31 2024, 06:11

Jul 30 2024

Fabien published D16539: Get rid of ConnectTrace for review.
Jul 30 2024, 20:11
Fabien closed D16554: Add a new chronik backup server.
Jul 30 2024, 19:48
Fabien committed rABCdd5d09f6e32a: Add a new chronik backup server (authored by Fabien).
Add a new chronik backup server
Jul 30 2024, 19:48
Fabien closed D16552: Bump version to 0.29.10.
Jul 30 2024, 14:41
Fabien committed rABCba0cf6a37268: Bump version to 0.29.10 (authored by Fabien).
Bump version to 0.29.10
Jul 30 2024, 14:41
Fabien requested review of D16554: Add a new chronik backup server.
Jul 30 2024, 14:40
Fabien accepted D16541: [Chronik] Add `/plugin/:plugin_name/:group_hex/utxos` HTTP endpoint.
Jul 30 2024, 14:17
Fabien accepted D16546: Bump Rust version to 1.80.
Jul 30 2024, 12:32
Fabien requested review of D16552: Bump version to 0.29.10.
Jul 30 2024, 12:21
Fabien requested changes to D16547: [Chronik] Find and add Bcrypt library.
Jul 30 2024, 12:19
teamcity awarded D16548: Bump minimum required Windows version to Windows 10 a Piece of Eight token.
Jul 30 2024, 11:01
teamcity awarded D16548: Bump minimum required Windows version to Windows 10 a Haypence token.
Jul 30 2024, 09:53
Fabien accepted D16545: [avalanche] Do not add the same payout script more than once when calling setstakingreward RPC.
Jul 30 2024, 07:15

Jul 29 2024

Fabien added inline comments to D16533: [explorer] Show the miner name in the block page.
Jul 29 2024, 18:22
Fabien requested changes to D16545: [avalanche] Do not add the same payout script more than once when calling setstakingreward RPC.
Jul 29 2024, 18:16
Fabien closed D16542: Make the longpoll much faster on regtest.
Jul 29 2024, 15:38
Fabien committed rABCfa9ae8f3e183: Make the longpoll much faster on regtest (authored by Fabien).
Make the longpoll much faster on regtest
Jul 29 2024, 15:38
Fabien requested review of D16542: Make the longpoll much faster on regtest.
Jul 29 2024, 13:11
Fabien added inline comments to D16533: [explorer] Show the miner name in the block page.
Jul 29 2024, 08:47
Fabien accepted D16537: [Chronik] Enable indexing txs by plugins + return protobuf.
Jul 29 2024, 08:23
Fabien accepted D16532: [Chronik] Add PluginsWrite::{insert, delete}.
Jul 29 2024, 08:05
Fabien accepted D16540: [Chronik] Add `MempoolPlugins`, run plugins on mempool txs.
Jul 29 2024, 08:05
Fabien accepted D16527: [Chronik] Add `PluginContext::run_on_tx`.
Jul 29 2024, 07:33
Fabien closed D16538: Improve the ZMQ functional test.
Jul 29 2024, 07:27
Fabien committed rABC748343d6c5ef: Improve the ZMQ functional test (authored by Fabien).
Improve the ZMQ functional test
Jul 29 2024, 07:27

Jul 27 2024

Fabien closed D16536: Log accept to mempool status after a reorg.
Jul 27 2024, 21:30
Fabien committed rABC9d5469121627: Log accept to mempool status after a reorg (authored by Fabien).
Log accept to mempool status after a reorg
Jul 27 2024, 21:30
Fabien requested review of D16538: Improve the ZMQ functional test.
Jul 27 2024, 21:05
Fabien requested review of D16536: Log accept to mempool status after a reorg.
Jul 27 2024, 15:56

Jul 25 2024

Fabien requested changes to D16532: [Chronik] Add PluginsWrite::{insert, delete}.

The build is failing, back to your queue

Jul 25 2024, 14:39
Fabien requested changes to D16527: [Chronik] Add `PluginContext::run_on_tx`.

Can you please add a couple tests with data=b'' and data=[] ? Note this can be unit tests for extract_bytes_or_list instead of the whole run_on_tx

Jul 25 2024, 14:38
Fabien accepted D16525: [Chronik] Add `plugin` field to `TxInput` in `tx.py`.
Jul 25 2024, 14:13
Fabien accepted D16526: [chronik] add a block-headers endpoint.
Jul 25 2024, 14:08
Fabien accepted D16508: [chronik] add a block-header endpoint.
Jul 25 2024, 14:02

Jul 24 2024

Fabien requested changes to D16526: [chronik] add a block-headers endpoint.

The deduplication was correct, you just called the boundary check later in the code flow which changed the behavior.

Jul 24 2024, 12:24
Fabien accepted D16530: [Chronik] Remove unneeded `.as_ref()` call.
Jul 24 2024, 12:11
Fabien added inline comments to D16525: [Chronik] Add `plugin` field to `TxInput` in `tx.py`.
Jul 24 2024, 10:19
Fabien accepted D16522: [Chronik] Store index of plugins and ensure versions match.
Jul 24 2024, 09:45
Fabien accepted D16520: [Chronik] Add `PluginsWriter` and `PluginsReader` (only for PluginMeta).

Is this test run as part of ninja check-crates ?

Jul 24 2024, 09:13

Jul 23 2024

Fabien requested changes to D16508: [chronik] add a block-header endpoint.

Otherwise LGTM

Jul 23 2024, 19:16
Fabien requested changes to D16526: [chronik] add a block-headers endpoint.

back to your queue

Jul 23 2024, 18:59
Fabien closed D16521: [explorer] Properly handle html chars in token ticker.
Jul 23 2024, 11:15
Fabien committed rABC7c5664b00bf6: [explorer] Properly handle html chars in token ticker (authored by Fabien).
[explorer] Properly handle html chars in token ticker
Jul 23 2024, 11:15
Fabien requested changes to D16508: [chronik] add a block-header endpoint.
Jul 23 2024, 08:01
Fabien requested review of D16521: [explorer] Properly handle html chars in token ticker.
Jul 23 2024, 07:32

Jul 22 2024

Fabien requested changes to D16516: [Cashtab] Add maintenance mode with config toggle.

The tests are failing

Jul 22 2024, 12:23
Fabien accepted D16514: [Cashtab] version bump for D16513.
Jul 22 2024, 08:53
Fabien accepted D16513: [Cashtab] Remove article hyperlink.
Jul 22 2024, 08:21
Fabien requested changes to D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat.
Jul 22 2024, 07:39

Jul 19 2024

Fabien closed D16507: fuzz: increase txorphan harness stability.
Jul 19 2024, 14:08
Fabien committed rABC0fafd7b7095f: fuzz: increase txorphan harness stability (authored by marcofleon <marleo23@proton.me>).
fuzz: increase txorphan harness stability
Jul 19 2024, 14:08
Fabien closed D16504: [log] updates in TxOrphanage.
Jul 19 2024, 14:08
Fabien committed rABCe7ca7c17ac73: [log] updates in TxOrphanage (authored by Fabien).
[log] updates in TxOrphanage
Jul 19 2024, 14:08
Fabien closed D16503: test: tx orphan handling.
Jul 19 2024, 14:07
Fabien committed rABC969e03c50dad: test: tx orphan handling (authored by glozow <gloriajzhao@gmail.com>).
test: tx orphan handling
Jul 19 2024, 14:07
Fabien closed D16505: net_processing: ignore transactions while in IBD.
Jul 19 2024, 14:06
Fabien committed rABC673bc1eb29cf: net_processing: ignore transactions while in IBD (authored by glozow <gzhao408@berkeley.edu>).
net_processing: ignore transactions while in IBD
Jul 19 2024, 14:06
Fabien closed D16506: fuzz: Improve fuzzing stability for txorphan harness.
Jul 19 2024, 14:04
Fabien committed rABC1e1bd1cbf62a: fuzz: Improve fuzzing stability for txorphan harness (authored by dergoegge <n.goeggi@gmail.com>).
fuzz: Improve fuzzing stability for txorphan harness
Jul 19 2024, 14:04
Fabien requested review of D16507: fuzz: increase txorphan harness stability.
Jul 19 2024, 12:48
Fabien requested review of D16506: fuzz: Improve fuzzing stability for txorphan harness.
Jul 19 2024, 12:23
Fabien updated the diff for D16504: [log] updates in TxOrphanage.

Rebase

Jul 19 2024, 11:58
Fabien updated the summary of D16503: test: tx orphan handling.
Jul 19 2024, 11:57
Fabien updated the diff for D16503: test: tx orphan handling.

Rebase on D16505.

Jul 19 2024, 11:57
Fabien requested review of D16505: net_processing: ignore transactions while in IBD.
Jul 19 2024, 11:55
Fabien planned changes to D16503: test: tx orphan handling.
Jul 19 2024, 11:18
Fabien requested review of D16504: [log] updates in TxOrphanage.
Jul 19 2024, 09:46
Fabien requested review of D16503: test: tx orphan handling.
Jul 19 2024, 09:32
Fabien closed D16502: test: Add more tests for orphan tx handling.
Jul 19 2024, 08:05
Fabien committed rABC3628e52ed106: test: Add more tests for orphan tx handling (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
test: Add more tests for orphan tx handling
Jul 19 2024, 08:05
Fabien closed D16501: refactor: Use type-safe time in txorphanage.
Jul 19 2024, 08:05
Fabien committed rABCa53da9376411: refactor: Use type-safe time in txorphanage (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
refactor: Use type-safe time in txorphanage
Jul 19 2024, 08:05
Fabien closed D16498: opportunistic 1p1c followups.
Jul 19 2024, 08:04
Fabien committed rABCbe7fbc1fd1be: opportunistic 1p1c followups (authored by glozow <gloriajzhao@gmail.com>).
opportunistic 1p1c followups
Jul 19 2024, 08:04

Jul 18 2024

Fabien requested review of D16502: test: Add more tests for orphan tx handling.
Jul 18 2024, 14:27
Fabien requested review of D16501: refactor: Use type-safe time in txorphanage.
Jul 18 2024, 13:28
Fabien closed D16494: [p2p] opportunistically accept 1-parent-1-child packages.
Jul 18 2024, 13:11
Fabien committed rABCd0b3d2524b06: [p2p] opportunistically accept 1-parent-1-child packages (authored by glozow <gloriajzhao@gmail.com>).
[p2p] opportunistically accept 1-parent-1-child packages
Jul 18 2024, 13:11
Fabien requested review of D16498: opportunistic 1p1c followups.
Jul 18 2024, 09:55
Fabien closed D16497: Avoid the p2p delays on some functional tests.
Jul 18 2024, 09:46
Fabien committed rABCd754f53dfaf3: Avoid the p2p delays on some functional tests (authored by Fabien).
Avoid the p2p delays on some functional tests
Jul 18 2024, 09:46
Fabien added inline comments to D16494: [p2p] opportunistically accept 1-parent-1-child packages.
Jul 18 2024, 09:15
Fabien updated the diff for D16494: [p2p] opportunistically accept 1-parent-1-child packages.

Fix comment nit, and remove the unecessary noban_tx_relay

Jul 18 2024, 09:13
Fabien closed D16493: [txorphanage] add method to get all orphans spending a tx.
Jul 18 2024, 09:06
Fabien committed rABC1f4999794394: [txorphanage] add method to get all orphans spending a tx (authored by glozow <gloriajzhao@gmail.com>).
[txorphanage] add method to get all orphans spending a tx
Jul 18 2024, 09:06
Fabien closed D16491: [txpackages] add canonical way to get hash of package.
Jul 18 2024, 09:05
Fabien committed rABC39a2132c1e7c: [txpackages] add canonical way to get hash of package (authored by glozow <gloriajzhao@gmail.com>).
[txpackages] add canonical way to get hash of package
Jul 18 2024, 09:05
Fabien closed D16490: rpc: allow submitpackage to be called outside of regtest.
Jul 18 2024, 09:03
Fabien committed rABC48cb63e4a344: rpc: allow submitpackage to be called outside of regtest (authored by glozow <gloriajzhao@gmail.com>).
rpc: allow submitpackage to be called outside of regtest
Jul 18 2024, 09:03
Fabien requested review of D16497: Avoid the p2p delays on some functional tests.
Jul 18 2024, 08:53

Jul 17 2024

Fabien updated the diff for D16494: [p2p] opportunistically accept 1-parent-1-child packages.

Using the same quote marks for an embedded dict key and its f-string is a Python 3.12+ feature, TIL

Jul 17 2024, 20:01
Fabien requested review of D16494: [p2p] opportunistically accept 1-parent-1-child packages.
Jul 17 2024, 19:20