C++11 loop style

In D1556#32179, @schancel wrote:

Seems like a good change. However, please fix the code style as per what I suggested. Just check for null first.

sometimes bip68-sequence.py test will fail which I think is irrelevant with this commit.

In D1556#32179, @schancel wrote:

Seems like a good change. However, please fix the code style as per what I suggested. Just check for null first.

seperate two ifs

In D1556#32053, @jasonbcox wrote:

Regarding linting errors, check clang-format --version and make sure you're on 4.x instead of 5 or 6.

fix string concat bug by use string directly.

In D1556#32053, @jasonbcox wrote:

Regarding linting errors, check clang-format --version and make sure you're on 4.x instead of 5 or 6.

update Test Plan & make rawtransaction test case better

In D1556#32034, @jasonbcox wrote:

Amaury is saying you need to add this to the test plan, at a minimum:

/test/functional/test_runner.py rawtransactions.py

This ensures you test changes pass locally before publishing the diff. :)

fix Code style violation

In D1556#32028, @deadalnix wrote:

make check is not an appropriate test for this. This is changing behavior, and such behavior needs to be tested. Please update the test plan accordingly.

Except this, LGTM.

fix some code formatting auto-done by editor.

In D1269#25085, @deadalnix wrote:

There was a diff that was accepted with a set of changes. If you want to do more, do other diffs.

fix translation in 'Warning: Invalid Bitcoin Cash address'

more translation found:

rename Bitcoin to Bitcoin Cash in cpp files work with translation

modify 'These are your Bitcoin Cash addresses'

some of the Bitcoin should be replaced to Bitcoin Cash in gui cpp files.

"Enter a Bitcoin address" this translation is broken, trying to find more.

In D1269#25022, @deadalnix wrote:

This wasn't the code that was accepted, and for good reason (this breaks various translations).

got, some of the Bitcoin should not be replaced to Bitcoin Cash. e.g. Bitcoin ABC

In D1254#24858, @deadalnix wrote:

This is way beyoond the scope of the orginal diff. Please revert and make a new diff for the other changes.

some of the Bitcoin is not replaced to Bicoin Cash in locale files, fix it

done, I checked the contribution.md before coding, if anything I missed, remind me please, thanks :)