Page MenuHomePhabricator

tobias_ruck (Tobias Ruck)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2020, 15:08 (267 w, 2 d)

Recent Activity

Yesterday

tobias_ruck requested changes to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Thu, Feb 20, 19:26

Sun, Feb 16

tobias_ruck closed D17667: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`.
Sun, Feb 16, 14:13
tobias_ruck committed rABCb9c39dc25864: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc` (authored by tobias_ruck).
[ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`
Sun, Feb 16, 14:13

Sat, Feb 15

tobias_ruck updated the diff for D17667: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`.

bump ecash-lib version

Sat, Feb 15, 19:49
tobias_ruck updated the summary of D17667: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`.
Sat, Feb 15, 19:08
tobias_ruck requested review of D17667: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`.
Sat, Feb 15, 19:02

Tue, Feb 11

tobias_ruck requested changes to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Tue, Feb 11, 11:31

Fri, Feb 7

tobias_ruck accepted D17648: [ecash-agora] Do not validate for unspendable offers when estimating the fee.
Fri, Feb 7, 17:24

Thu, Feb 6

tobias_ruck closed D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.
Thu, Feb 6, 18:24
tobias_ruck committed rABCfbb3bb406999: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters (authored by tobias_ruck).
[ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters
Thu, Feb 6, 18:24
tobias_ruck requested changes to D17464: [ecash-lib] attach ecc and hashes to globalThis.

This has been made obsolete by D17639.

Thu, Feb 6, 18:05
tobias_ruck updated the diff for D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.

also update README.md in ecash-agora

Thu, Feb 6, 18:01
tobias_ruck updated the diff for D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.

address review

Thu, Feb 6, 17:52
tobias_ruck closed D17639: [ecash-lib] Remove `initWasm`.
Thu, Feb 6, 17:46
tobias_ruck committed rABC3b1bf6f9ff46: [ecash-lib] Remove `initWasm` (authored by tobias_ruck).
[ecash-lib] Remove `initWasm`
Thu, Feb 6, 17:46
tobias_ruck added a comment to D17639: [ecash-lib] Remove `initWasm`.

nice, huge step change for dev experience, and esp for apps that use ecash-lib and ecash-agora

Thu, Feb 6, 09:12
tobias_ruck updated the diff for D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.

improve README.md

Thu, Feb 6, 01:52
tobias_ruck updated the diff for D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.

remove package-lock.json

Thu, Feb 6, 01:37
tobias_ruck updated the diff for D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.

fix some more build errors

Thu, Feb 6, 01:34
tobias_ruck updated the diff for D17639: [ecash-lib] Remove `initWasm`.

simplify usage

Thu, Feb 6, 01:30
tobias_ruck updated the diff for D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.

fix tests

Thu, Feb 6, 01:22
tobias_ruck updated the summary of D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.
Thu, Feb 6, 00:53
tobias_ruck requested review of D17640: [ecash-lib] [ecash-agora] Remove unneeded `ecc` parameters.
Thu, Feb 6, 00:52
tobias_ruck added inline comments to D17639: [ecash-lib] Remove `initWasm`.
Thu, Feb 6, 00:52
tobias_ruck published D17639: [ecash-lib] Remove `initWasm` for review.
Thu, Feb 6, 00:49

Fri, Jan 31

tobias_ruck closed D17622: [ecash-lib] Support custom WASM URL and module.
Fri, Jan 31, 22:22
tobias_ruck committed rABC92f16ad6b35e: [ecash-lib] Support custom WASM URL and module (authored by tobias_ruck).
[ecash-lib] Support custom WASM URL and module
Fri, Jan 31, 22:22
tobias_ruck updated the summary of D17622: [ecash-lib] Support custom WASM URL and module.
Fri, Jan 31, 21:59
tobias_ruck updated the diff for D17622: [ecash-lib] Support custom WASM URL and module.

add diff url

Fri, Jan 31, 21:56
tobias_ruck requested review of D17622: [ecash-lib] Support custom WASM URL and module.
Fri, Jan 31, 21:55
tobias_ruck closed D17621: [ecash-lib] Patch import in `mnemonic.ts`.
Fri, Jan 31, 21:03
tobias_ruck committed rABC2ccbb46a96c1: [ecash-lib] Patch import in `mnemonic.ts` (authored by tobias_ruck).
[ecash-lib] Patch import in `mnemonic.ts`
Fri, Jan 31, 21:03
tobias_ruck updated the diff for D17621: [ecash-lib] Patch import in `mnemonic.ts`.

include diff url

Fri, Jan 31, 20:50
tobias_ruck requested review of D17621: [ecash-lib] Patch import in `mnemonic.ts`.
Fri, Jan 31, 20:49
tobias_ruck closed D17619: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality.
Fri, Jan 31, 18:03
tobias_ruck committed rABC57bd51505b46: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality (authored by tobias_ruck).
[ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality
Fri, Jan 31, 18:03
tobias_ruck updated the diff for D17619: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality.

bump version using npm, add link to diff

Fri, Jan 31, 17:32
tobias_ruck updated the summary of D17619: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality.
Fri, Jan 31, 17:30
tobias_ruck requested review of D17619: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality.
Fri, Jan 31, 13:45
tobias_ruck closed D17614: [ecash-lib] Add `HdNode` for HD wallets.
Fri, Jan 31, 13:23
tobias_ruck committed rABC0992b4fdbcf9: [ecash-lib] Add `HdNode` for HD wallets (authored by tobias_ruck).
[ecash-lib] Add `HdNode` for HD wallets
Fri, Jan 31, 13:23
tobias_ruck closed D17612: [ecash-lib] Add mnemonic functionality.
Fri, Jan 31, 12:03
tobias_ruck committed rABCe8c7c10070f5: [ecash-lib] Add mnemonic functionality (authored by tobias_ruck).
[ecash-lib] Add mnemonic functionality
Fri, Jan 31, 12:03
tobias_ruck closed D17610: [ecash-lib] Add `pbkdf2`.
Fri, Jan 31, 12:00
tobias_ruck committed rABC01abe1438cf6: [ecash-lib] Add `pbkdf2` (authored by tobias_ruck).
[ecash-lib] Add `pbkdf2`
Fri, Jan 31, 12:00

Thu, Jan 30

tobias_ruck updated the diff for D17614: [ecash-lib] Add `HdNode` for HD wallets.

add =, rebase

Thu, Jan 30, 22:43
tobias_ruck added a comment to D17614: [ecash-lib] Add `HdNode` for HD wallets.

Could you give a few sentences about the approach used here and how it differs from the legacy lib?

Thu, Jan 30, 22:39
tobias_ruck updated the diff for D17612: [ecash-lib] Add mnemonic functionality.

use more consts

Thu, Jan 30, 22:32
tobias_ruck added inline comments to D17612: [ecash-lib] Add mnemonic functionality.
Thu, Jan 30, 22:20
tobias_ruck added a comment to D17612: [ecash-lib] Add mnemonic functionality.

very nice to have this in our own lib but we do lose the empirical validation of the bip39 lib, i.e. this has been used for years in wallets without any known issues in "truly random" seed generation.

Thu, Jan 30, 22:17
tobias_ruck requested review of D17610: [ecash-lib] Add `pbkdf2`.
Thu, Jan 30, 22:09
tobias_ruck published D17614: [ecash-lib] Add `HdNode` for HD wallets for review.
Thu, Jan 30, 16:05
tobias_ruck requested review of D17612: [ecash-lib] Add mnemonic functionality.
Thu, Jan 30, 13:34
tobias_ruck published D17610: [ecash-lib] Add `pbkdf2` for review.
Thu, Jan 30, 09:43
tobias_ruck closed D17609: [ecash-lib] Add SHA512 support, hashers and `Hmac`.
Thu, Jan 30, 09:43
tobias_ruck committed rABC37bb5ed18b08: [ecash-lib] Add SHA512 support, hashers and `Hmac` (authored by tobias_ruck).
[ecash-lib] Add SHA512 support, hashers and `Hmac`
Thu, Jan 30, 09:43
tobias_ruck requested review of D17609: [ecash-lib] Add SHA512 support, hashers and `Hmac`.
Thu, Jan 30, 03:47

Jan 15 2025

tobias_ruck added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 21:38

Jan 14 2025

tobias_ruck added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 14 2025, 20:50

Jan 13 2025

tobias_ruck accepted D17517: [ecash-agora] Do not allow creation of unacceptable agora partials.
Jan 13 2025, 22:01
tobias_ruck added inline comments to D17422: [ecash-agora] Upgrade historicOffers to return token amounts purchased (and price).
Jan 13 2025, 21:40
tobias_ruck added inline comments to D17464: [ecash-lib] attach ecc and hashes to globalThis.
Jan 13 2025, 15:56
tobias_ruck accepted D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Jan 13 2025, 15:51
tobias_ruck added a comment to D17522: [chronik] rename the MerkleTree struct.

Can you change the title to indicate this is just a rename? It seemed to me as this would generalize behavior somehow (e.g. adding a generic param)

Jan 13 2025, 15:49
tobias_ruck requested changes to D17464: [ecash-lib] attach ecc and hashes to globalThis.
Jan 13 2025, 10:19

Jan 4 2025

tobias_ruck requested changes to D17464: [ecash-lib] attach ecc and hashes to globalThis.
Jan 4 2025, 14:14

Jan 3 2025

tobias_ruck accepted D17461: [ecash-lib] Patch for nodejs tx building.
Jan 3 2025, 22:03

Dec 20 2024

tobias_ruck requested changes to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Dec 20 2024, 09:52
tobias_ruck accepted D17375: [faucet] CI fix.
Dec 20 2024, 00:46
tobias_ruck accepted D17374: [CI fixes for ecashaddrjs diff] Update dockerfiles for CI impacts of lib change.
Dec 20 2024, 00:24

Dec 19 2024

tobias_ruck accepted D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 19 2024, 23:24
tobias_ruck accepted D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 19 2024, 22:21

Dec 18 2024

tobias_ruck added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

What is the benefit vs a no-op ? Imagine I'm a mining pool and I want to convert all my miner addresses to legacy (real world use case) even if they are using BCH or XEC addresses. I would like to just use to_legacy() and not have to first check it's not legacy format already

Dec 18 2024, 20:41

Dec 16 2024

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 16 2024, 14:22
tobias_ruck accepted D17347: [chronik] add macros to extract params from a JSONRPC request.

very cool!

Dec 16 2024, 13:38
tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 16 2024, 12:27
tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 16 2024, 10:11
tobias_ruck accepted D17314: [chronik] add a test for the new JSON RPC interface.
Dec 16 2024, 10:03

Dec 15 2024

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 15 2024, 23:38

Dec 14 2024

tobias_ruck added inline comments to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 14 2024, 13:29
tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 14 2024, 13:29

Dec 13 2024

tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 13 2024, 18:20
tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 13 2024, 10:26

Dec 12 2024

tobias_ruck accepted D17333: [chronik] Add support for TLS to the electrum server.
Dec 12 2024, 11:08
tobias_ruck requested changes to D17333: [chronik] Add support for TLS to the electrum server.
Dec 12 2024, 10:37
tobias_ruck requested changes to D17333: [chronik] Add support for TLS to the electrum server.
Dec 12 2024, 09:05

Dec 11 2024

tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 11 2024, 20:14
tobias_ruck accepted D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.
Dec 11 2024, 12:05

Dec 10 2024

tobias_ruck added a comment to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

@bot build-explorer

Dec 10 2024, 21:07

Dec 7 2024

tobias_ruck requested changes to D17314: [chronik] add a test for the new JSON RPC interface.
Dec 7 2024, 18:24
tobias_ruck accepted D17313: [bitcoin-abc][web] Moved explorer dockerfile to root so it can access Cargo.lock.
Dec 7 2024, 15:05
tobias_ruck added a comment to D17313: [bitcoin-abc][web] Moved explorer dockerfile to root so it can access Cargo.lock.

@bot preview-explorer

Dec 7 2024, 14:59
tobias_ruck accepted D17312: [Bitcoin-abc] Fixed CI, removed Cargo.lock duplicates.
Dec 7 2024, 13:41

Dec 6 2024

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 6 2024, 22:06
tobias_ruck updated the diff for D17001: [64-bit ints] Add overflow checks to CScriptNum for +, -, +=, -=.

address review

Dec 6 2024, 21:13
tobias_ruck added inline comments to D16997: [64-bit ints] Refactor `CScriptNum` to require setting `nMaxNumSize`.
Dec 6 2024, 20:57
tobias_ruck added inline comments to D17001: [64-bit ints] Add overflow checks to CScriptNum for +, -, +=, -=.
Dec 6 2024, 20:41
tobias_ruck added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 6 2024, 20:38
tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 6 2024, 14:45
tobias_ruck published D17001: [64-bit ints] Add overflow checks to CScriptNum for +, -, +=, -= for review.
Dec 6 2024, 11:55