People tobias_ruck

tobias_ruck (Tobias Ruck)
User

Projects

User does not belong to any projects.

User Details

User Since: Jan 7 2020, 15:08 (262 w, 3 d)

Recent Activity
View All

Wed, Jan 15

tobias_ruck added inline comments to D17527: [ecash-lib] Add toHex method to Script class.

Wed, Jan 15, 21:38

Tue, Jan 14

tobias_ruck added inline comments to D17527: [ecash-lib] Add toHex method to Script class.

Tue, Jan 14, 20:50

Mon, Jan 13

tobias_ruck accepted D17517: [ecash-agora] Do not allow creation of unacceptable agora partials.

Mon, Jan 13, 22:01

tobias_ruck added inline comments to D17422: [ecash-agora] Upgrade historicOffers to return token amounts purchased (and price).

Mon, Jan 13, 21:40

tobias_ruck added inline comments to D17464: [ecash-lib] attach ecc and hashes to globalThis.

Mon, Jan 13, 15:56

tobias_ruck accepted D17370: [chronik] add blockchain.transaction.broadcast electrum method.

Mon, Jan 13, 15:51

tobias_ruck added a comment to D17522: [chronik] rename the MerkleTree struct.

Can you change the title to indicate this is just a rename? It seemed to me as this would generalize behavior somehow (e.g. adding a generic param)

Mon, Jan 13, 15:49

tobias_ruck requested changes to D17464: [ecash-lib] attach ecc and hashes to globalThis.

Mon, Jan 13, 10:19

Sat, Jan 4

tobias_ruck requested changes to D17464: [ecash-lib] attach ecc and hashes to globalThis.

Sat, Jan 4, 14:14

Fri, Jan 3

tobias_ruck accepted D17461: [ecash-lib] Patch for nodejs tx building.

Fri, Jan 3, 22:03

Fri, Dec 20

tobias_ruck requested changes to D17370: [chronik] add blockchain.transaction.broadcast electrum method.

Fri, Dec 20, 09:52

tobias_ruck accepted D17375: [faucet] CI fix.

Fri, Dec 20, 00:46

tobias_ruck accepted D17374: [CI fixes for ecashaddrjs diff] Update dockerfiles for CI impacts of lib change.

Fri, Dec 20, 00:24

Thu, Dec 19

tobias_ruck accepted D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Thu, Dec 19, 23:24

tobias_ruck accepted D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Thu, Dec 19, 22:21

Wed, Dec 18

tobias_ruck added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

In D17269#394989, @Fabien wrote:

What is the benefit vs a no-op ? Imagine I'm a mining pool and I want to convert all my miner addresses to legacy (real world use case) even if they are using BCH or XEC addresses. I would like to just use to_legacy() and not have to first check it's not legacy format already

Wed, Dec 18, 20:41

Dec 16 2024

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Dec 16 2024, 14:22

tobias_ruck accepted D17347: [chronik] add macros to extract params from a JSONRPC request.

very cool!

Dec 16 2024, 13:38

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Dec 16 2024, 12:27

tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Dec 16 2024, 10:11

tobias_ruck accepted D17314: [chronik] add a test for the new JSON RPC interface.

Dec 16 2024, 10:03

Dec 15 2024

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Dec 15 2024, 23:38

Dec 14 2024

tobias_ruck added inline comments to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Dec 14 2024, 13:29

tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Dec 14 2024, 13:29

Dec 13 2024

tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Dec 13 2024, 18:20

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Dec 13 2024, 10:26

Dec 12 2024

tobias_ruck accepted D17333: [chronik] Add support for TLS to the electrum server.

Dec 12 2024, 11:08

tobias_ruck requested changes to D17333: [chronik] Add support for TLS to the electrum server.

Dec 12 2024, 10:37

tobias_ruck requested changes to D17333: [chronik] Add support for TLS to the electrum server.

Dec 12 2024, 09:05

Dec 11 2024

tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Dec 11 2024, 20:14

tobias_ruck accepted D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

Dec 11 2024, 12:05

Dec 10 2024

tobias_ruck added a comment to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

@bot build-explorer

Dec 10 2024, 21:07

Dec 7 2024

tobias_ruck requested changes to D17314: [chronik] add a test for the new JSON RPC interface.

Dec 7 2024, 18:24

tobias_ruck accepted D17313: [bitcoin-abc][web] Moved explorer dockerfile to root so it can access Cargo.lock.

Dec 7 2024, 15:05

tobias_ruck added a comment to D17313: [bitcoin-abc][web] Moved explorer dockerfile to root so it can access Cargo.lock.

@bot preview-explorer

Dec 7 2024, 14:59

tobias_ruck accepted D17312: [Bitcoin-abc] Fixed CI, removed Cargo.lock duplicates.

Dec 7 2024, 13:41

Dec 6 2024

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Dec 6 2024, 22:06

tobias_ruck updated the diff for D17001: [64-bit ints] Add overflow checks to CScriptNum for +, -, +=, -=.

address review

Dec 6 2024, 21:13

tobias_ruck added inline comments to D16997: [64-bit ints] Refactor `CScriptNum` to require setting `nMaxNumSize`.

Dec 6 2024, 20:57

tobias_ruck added inline comments to D17001: [64-bit ints] Add overflow checks to CScriptNum for +, -, +=, -=.

Dec 6 2024, 20:41

tobias_ruck added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Dec 6 2024, 20:38

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Dec 6 2024, 14:45

tobias_ruck published D17001: [64-bit ints] Add overflow checks to CScriptNum for +, -, +=, -= for review.

Dec 6 2024, 11:55

tobias_ruck requested changes to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

Dec 6 2024, 11:25

tobias_ruck published D16997: [64-bit ints] Refactor `CScriptNum` to require setting `nMaxNumSize` for review.

Dec 6 2024, 10:27

tobias_ruck added a comment to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

@bot build-explorer

Dec 6 2024, 10:24

Dec 5 2024

tobias_ruck accepted D17185: [chronik] Create a new optional JSON RPC interface.

Dec 5 2024, 23:59

tobias_ruck closed D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

Dec 5 2024, 23:56

tobias_ruck committed rABCd9bedb004bfb: [64-bit ints] Change `CScriptNum::getint` to return `int64_t` (authored by tobias_ruck).

[64-bit ints] Change `CScriptNum::getint` to return `int64_t`

Dec 5 2024, 23:56

tobias_ruck closed D17290: [64-bit ints] Add script_tests for `getint` coverage.

Dec 5 2024, 23:48

tobias_ruck committed rABCf67fd8dd5fd8: [64-bit ints] Add script_tests for `getint` coverage (authored by tobias_ruck).

[64-bit ints] Add script_tests for `getint` coverage

Dec 5 2024, 23:48

tobias_ruck requested changes to D17185: [chronik] Create a new optional JSON RPC interface.

Dec 5 2024, 18:05

tobias_ruck updated the diff for D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

fix CheckNegate

Dec 5 2024, 17:27

tobias_ruck added inline comments to D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

Dec 5 2024, 17:24

tobias_ruck closed D17000: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file.

Dec 5 2024, 17:16

tobias_ruck committed rABC805a0f137bf6: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file (authored by tobias_ruck).

[64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file

Dec 5 2024, 17:16

tobias_ruck updated the diff for D17290: [64-bit ints] Add script_tests for `getint` coverage.

add rationales

Dec 5 2024, 17:14

Dec 4 2024

tobias_ruck updated the summary of D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

Dec 4 2024, 23:18

tobias_ruck updated the summary of D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

Dec 4 2024, 23:06

tobias_ruck updated the diff for D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

address review, remove CScriptNum10 and replace tests with tests that test the behavior of CScriptNum instead of testing whether it matches CScriptNum10

Dec 4 2024, 23:02

tobias_ruck requested review of D17290: [64-bit ints] Add script_tests for `getint` coverage.

Dec 4 2024, 22:33

tobias_ruck updated the diff for D17000: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file.

address review

Dec 4 2024, 22:02

tobias_ruck added inline comments to D17185: [chronik] Create a new optional JSON RPC interface.

Dec 4 2024, 21:48

tobias_ruck requested changes to D17185: [chronik] Create a new optional JSON RPC interface.

Dec 4 2024, 21:45

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Dec 4 2024, 21:22

tobias_ruck requested changes to D17272: [CHRONIK][WEB][MODULES] Updated every out of date dependency in Cargo.toml that does not require code change.

The explorer build is failing (CI doesn't catch this yet):

Dec 4 2024, 12:21

Dec 3 2024

tobias_ruck accepted D17283: [test] Only sync proofs when avalanche is enabled.

Dec 3 2024, 13:25

tobias_ruck accepted D17282: Add a new getinfo rpc.

Dec 3 2024, 13:21

Dec 2 2024

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Dec 2 2024, 23:45

tobias_ruck accepted D17267: [CHRONIK][WEB][MODULES] Updated thiserror from 1.0 -> 2.0.3 in Cargo.toml.

Dec 2 2024, 22:45

tobias_ruck accepted D17277: [cmake] Fix -Wunused-command-line-argument with clang.

works for me

Dec 2 2024, 22:25

tobias_ruck added a comment to D17276: [guix] Build chronik for OSX.

🎉

Dec 2 2024, 20:30

Dec 1 2024

tobias_ruck requested changes to D17267: [CHRONIK][WEB][MODULES] Updated thiserror from 1.0 -> 2.0.3 in Cargo.toml.

Dec 1 2024, 22:30

tobias_ruck added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Dec 1 2024, 16:12

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

Generally I’m not sure if we should try to keep the interface the same. There’s an opportunity to simplify it (since users have to move to ecash-lib already anyway), and I think having just one encode/decode/Address will make the lib much easier to use

Dec 1 2024, 14:59

tobias_ruck requested changes to D17267: [CHRONIK][WEB][MODULES] Updated thiserror from 1.0 -> 2.0.3 in Cargo.toml.

Dec 1 2024, 00:29

tobias_ruck requested changes to D17267: [CHRONIK][WEB][MODULES] Updated thiserror from 1.0 -> 2.0.3 in Cargo.toml.

Dec 1 2024, 00:07

Nov 30 2024

tobias_ruck closed D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS.

Nov 30 2024, 10:36

tobias_ruck committed rABCbd800eb3d79c: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS (authored by tobias_ruck).

[b58-ts] Add `b58-ts` library for base58 en-/decoding in TS

Nov 30 2024, 10:36

teamcity awarded D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS a Love token.

Nov 30 2024, 10:34

tobias_ruck added a comment to D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS.

@bot b58-ts-tests

Nov 30 2024, 10:34

tobias_ruck updated the diff for D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS.

remove ecash-lib dev dependency
coerce integer math, don't use Math.ceil

Nov 30 2024, 10:31

teamcity awarded D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS a Like token.

Nov 30 2024, 02:29

tobias_ruck added a comment to D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS.

@bot b58-ts-tests

Nov 30 2024, 02:29

tobias_ruck updated the diff for D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS.

add tsconfig.build.json

Nov 30 2024, 02:28

tobias_ruck published D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS for review.

Nov 30 2024, 02:08

teamcity awarded D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS a Mountain of Wealth token.

Nov 30 2024, 02:05

teamcity awarded D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS a Doubloon token.

Nov 30 2024, 02:03

teamcity awarded D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS a Piece of Eight token.

Nov 30 2024, 02:00

teamcity awarded D17260: [b58-ts] Add `b58-ts` library for base58 en-/decoding in TS a Haypence token.

Nov 30 2024, 01:58

Nov 29 2024

tobias_ruck closed D17255: [ecash-lib] Add support for LEGACY sighash.

Nov 29 2024, 21:50

tobias_ruck committed rABC05f362591ab6: [ecash-lib] Add support for LEGACY sighash (authored by tobias_ruck).

[ecash-lib] Add support for LEGACY sighash

Nov 29 2024, 21:50

tobias_ruck updated the diff for D17255: [ecash-lib] Add support for LEGACY sighash.

format comment

Nov 29 2024, 19:23

tobias_ruck requested review of D17255: [ecash-lib] Add support for LEGACY sighash.

Nov 29 2024, 19:19

tobias_ruck planned changes to D17193: [ecash-lib] Add support for LEGACY sighash.

wait for the avalanche fix

Nov 29 2024, 18:57

tobias_ruck updated the diff for D17193: [ecash-lib] Add support for LEGACY sighash.

forward process env

Nov 29 2024, 18:35

tobias_ruck updated the diff for D17193: [ecash-lib] Add support for LEGACY sighash.

fix shasum calc

Nov 29 2024, 17:51

tobias_ruck accepted D17242: [CHRONIK] Updated pyo3 version.

Nov 29 2024, 17:06

tobias_ruck updated the diff for D17193: [ecash-lib] Add support for LEGACY sighash.

move doged download into the functional test

Nov 29 2024, 17:00

tobias_ruck updated the summary of D17193: [ecash-lib] Add support for LEGACY sighash.

Nov 29 2024, 15:59