HomePhabricator

Move direct calls to MessageSign into new SignMessage functions in CWallet and…

Description

Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan

Summary:
Instead of getting a SigningProvider and then going to MessageSign,
have ScriptPubKeyMan handle the message signing internally.

Backport of Core PR18115 part [7/9] : https://github.com/bitcoin/bitcoin/pull/18115/commits/6a9c429084b40356aa36aa67992da35f61c2f6a2

Depends on D8101 and D8098

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8102

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Feb 13 2020, 22:09
deadalnixCommitted on Oct 25 2020, 15:17
deadalnixPushed on Oct 25 2020, 15:17
Reviewer
Restricted Project
Differential Revision
D8102: Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan
Parents
rABCbee3cb09b38b: Move key and script filling and signing from CWallet::FillPSBT to…
Branches
Unknown
Tags
Unknown