HomePhabricator

validation: Move invalid block handling to CChainState

Description

validation: Move invalid block handling to CChainState

Summary:
Notes:

  • InvalidChainFound was already moved to CChainState in D7573
  • CheckForkWarningConditionsOnNewFork was removed by core in core#19905 because it doesn't work, but in Bitcoin ABC it was fixed in D1950.

This is a backport of core#21055 [8/16]
https://github.com/bitcoin/bitcoin/pull/21055/commits/8b99efbcc08ab41caf657c6d730a27e6a91bc356

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11213

Details

Provenance
Carl Dong <contact@carldong.me>Authored on Oct 5 2020, 19:14
PiRKCommitted on Mar 18 2022, 09:50
PiRKPushed on Mar 18 2022, 09:50
Reviewer
Restricted Project
Differential Revision
D11213: validation: Move invalid block handling to CChainState
Parents
rABC6a8d50e7f9a5: validation: Pass in chainstate to CVerifyDB::VerifyDB
Branches
Unknown
Tags
Unknown