Page MenuHomePhabricator

Use CheckForkWarningConditionsOnNewFork from FindMostWorkChain
ClosedPublic

Authored by deadalnix on Oct 20 2018, 19:45.

Details

Summary

Also pass the proper chain tip from ActivateBestChainStep. this ensure that we know the whole extent of the chain.

Changed the error message to reflect the fact that there is no guarantee that the chain is valid at all.

Test Plan
make check
./src/bitcoind -regtest -printtoconsole
./src/bitcoin-cli generate 100
./src/bitcoin-cli invalidateblock <block hash that is 6+ block deep>

Check that the alert message triggers now.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Oct 21 2018, 01:46
This revision was automatically updated to reflect the committed changes.