Page MenuHomePhabricator

Add a RPC call to park a chain
ClosedPublic

Authored by deadalnix on Oct 21 2018, 01:09.

Details

Summary

As per title. This allows to finally test the parking feature a bit more.

Depends on D1950

Test Plan

Added an integration test to ensure RPC call behave as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Oct 21 2018, 01:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2018, 01:09
jasonbcox requested changes to this revision.Oct 21 2018, 02:21
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rpc/blockchain.cpp
1541 ↗(On Diff #5474)

const

1621 ↗(On Diff #5474)

const

src/validation.cpp
2726 ↗(On Diff #5474)

invalid -> invalidate

Otherwise it sounds like a condition on the state being passed in.

2789 ↗(On Diff #5474)

newSatus -> newStatus

2808 ↗(On Diff #5474)

newSatus -> newStatus

test/functional/abc-parkedchain.py
5 ↗(On Diff #5474)

parckblock -> parkblock

This revision now requires changes to proceed.Oct 21 2018, 02:21
deadalnix updated this revision to Diff 5477.Oct 21 2018, 09:55

Address comments

deadalnix updated this revision to Diff 5487.Oct 21 2018, 18:29

Fix status update.

jasonbcox accepted this revision.Oct 22 2018, 21:02
This revision is now accepted and ready to land.Oct 22 2018, 21:02
This revision was automatically updated to reflect the committed changes.