Page MenuHomePhabricator
Differential D1952

Add a RPC call to park a chain
ClosedPublic
Actions

Authored by deadalnix on Oct 21 2018, 01:09.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING2de68f6eb0f9: Add a RPC call to park a chain
rABC2de68f6eb0f9: Add a RPC call to park a chain
Summary

As per title. This allows to finally test the parking feature a bit more.

Depends on D1950

Test Plan

Added an integration test to ensure RPC call behave as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
parkedrpc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3649
Build 5373: Bitcoin ABC Buildbot (legacy)
Build 5372: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 21 2018, 01:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2018, 01:09
deadalnix edited the summary of this revision. (Show Details)Oct 21 2018, 01:10
deadalnix added a parent revision: D1950: Use CheckForkWarningConditionsOnNewFork from FindMostWorkChain.
teamcity added a subscriber: teamcity.Oct 21 2018, 01:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 21 2018, 01:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3638: Diff 5474.Oct 21 2018, 01:19
jasonbcox requested changes to this revision.Oct 21 2018, 02:21
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rpc/blockchain.cpp
1541 ↗(On Diff #5474)

const

1621 ↗(On Diff #5474)

const

src/validation.cpp
2726 ↗(On Diff #5474)

invalid -> invalidate

Otherwise it sounds like a condition on the state being passed in.

2789 ↗(On Diff #5474)

newSatus -> newStatus

2808 ↗(On Diff #5474)

newSatus -> newStatus

test/functional/abc-parkedchain.py
5 ↗(On Diff #5474)

parckblock -> parkblock

This revision now requires changes to proceed.Oct 21 2018, 02:21
deadalnix updated this revision to Diff 5477.Oct 21 2018, 09:55

Address comments

teamcity added a comment.Oct 21 2018, 09:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 21 2018, 10:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3639: Diff 5477.Oct 21 2018, 10:07
deadalnix updated this revision to Diff 5487.Oct 21 2018, 18:29

Fix status update.

teamcity added a comment.Oct 21 2018, 18:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3649: Diff 5487!Oct 21 2018, 18:37
teamcity added a comment.Oct 21 2018, 18:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

jasonbcox accepted this revision.Oct 22 2018, 21:02
This revision is now accepted and ready to land.Oct 22 2018, 21:02
deadalnix updated this revision to Diff 5511.Oct 23 2018, 00:59

rebase

teamcity added a comment.Oct 23 2018, 01:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3665: Diff 5511.Oct 23 2018, 01:08
teamcity added a comment.Oct 23 2018, 01:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC2de68f6eb0f9: Add a RPC call to park a chain (authored by deadalnix). · Explain WhyOct 23 2018, 22:14
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in D4758: Call InvalidateBlock without cs_main held.Dec 18 2019, 23:23

Revision Contents
Changeset List

PathSize
src/
16 lines
rpc/
87 lines
test/
2 lines
7 lines
84 lines
test/
functional/
38 lines
158 lines

Diff 5487

View Options

src/blockstatus.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/test/blockstatus_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-parkedchain.py

Loading...
View Options

test/functional/timing.json

Loading...