Page MenuHomePhabricator

Add a RPC call to park a chain
ClosedPublic

Authored by deadalnix on Oct 21 2018, 01:09.

Details

Summary

As per title. This allows to finally test the parking feature a bit more.

Depends on D1950

Test Plan

Added an integration test to ensure RPC call behave as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
parkedrpc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3638
Build 5351: Bitcoin ABC Buildbot (legacy)
Build 5350: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Oct 21 2018, 02:21
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rpc/blockchain.cpp
1541

const

1621

const

src/validation.cpp
2726

invalid -> invalidate

Otherwise it sounds like a condition on the state being passed in.

2789

newSatus -> newStatus

2808

newSatus -> newStatus

test/functional/abc-parkedchain.py
5

parckblock -> parkblock

This revision now requires changes to proceed.Oct 21 2018, 02:21
This revision is now accepted and ready to land.Oct 22 2018, 21:02
This revision was automatically updated to reflect the committed changes.