Page MenuHomePhabricator

[refactor] make InvalidChainFound part of CChainState's implementation
ClosedPublic

Authored by majcosta on Fri, Sep 25, 19:59.

Details

Summary

This is only called by other methods of CChainState so make it private.

Depends on D7440

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix requested changes to this revision.Fri, Sep 25, 22:38
deadalnix added a subscriber: deadalnix.

I don't see how that helps? If doesn't look like it needs to access local state of the function, so making is static is better.

Unless you have some plan to move the state it uses, like pindexBestInvalid into CChainState ?

In which case, you need to provide a rationale for this refactoring.

This revision now requires changes to proceed.Fri, Sep 25, 22:38
This revision is now accepted and ready to land.Fri, Sep 25, 22:52