This is only called by other methods of CChainState so make it private.
Depends on D7440
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABCb79442f0795d: [refactor] make InvalidChainFound part of CChainState's implementation
ninja check check-functional
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- make_invalidchain_cchainstate
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 12932 Build 25931: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-clang-10 · build-clang-tidy Build 25930: arc lint + arc unit
Event Timeline
Comment Actions
I don't see how that helps? If doesn't look like it needs to access local state of the function, so making is static is better.
Unless you have some plan to move the state it uses, like pindexBestInvalid into CChainState ?
In which case, you need to provide a rationale for this refactoring.