HomePhabricator

[electrum] add test coverage for base58 address encoding

Description

[electrum] add test coverage for base58 address encoding

Summary:
Review of D16278 revealed that there is not test coverage for hash160_to_p2sh

Add a test vector for this function and two adjacent functions.

Cleanup TestBitcoin._do_test_crypto: remove a to call to public_key_to_p2pkh whose return value was ignored. We add coverage in the new test for this function.

Depends on D16277

Test Plan: python -m electrumabc.tests.test_bitcoin

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16303

Details

Provenance
PiRKAuthored on Thu, Jun 6, 09:43
PiRKPushed on Thu, Jun 6, 12:58
Reviewer
Restricted Project
Differential Revision
D16303: [electrum] add test coverage for base58 address encoding
Parents
rABC6877d06fc660: [electrum] move-only: split part of bitcoin.py into crypto.py
Branches
Unknown
Tags
Unknown