Page MenuHomePhabricator
Differential D16278

[electrum] move-only: extract more crypto code from bitcoin.py into ecc.py
ClosedPublic
Actions

Authored by PiRK on Jun 5 2024, 08:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0de5b333b9d5: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py
Summary

This is ecc.py move-only part of the original commit.

Inspired by https://github.com/spesmilo/electrum/commit/16e4827e8c6db833b0a969351b73eb34d489681f

Depends on D16303

Test Plan

python test_runner.py

Run the application, test basic features ./electrum-abc

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 5 2024, 08:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2024, 08:19
PiRK requested review of this revision.Jun 5 2024, 08:19
Harbormaster completed remote builds in B29217: Diff 48104.Jun 5 2024, 08:21
PiRK added a child revision: D16279: [electrum] move-only: split bip32 from bitcoin.py.Jun 5 2024, 08:22
PiRK edited the summary of this revision. (Show Details)Jun 5 2024, 08:27
Fabien requested changes to this revision.Jun 5 2024, 10:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/bitcoin.py
335 ↗(On Diff #48104)

?

This revision now requires changes to proceed.Jun 5 2024, 10:02
PiRK added inline comments.Jun 5 2024, 11:32
electrum/electrumabc/bitcoin.py
335 ↗(On Diff #48104)
	😬
PiRK updated this revision to Diff 48113.Jun 5 2024, 11:34

fix typo

Harbormaster completed remote builds in B29222: Diff 48113.Jun 5 2024, 11:37
Fabien requested changes to this revision.Jun 5 2024, 18:20
Fabien added inline comments.
electrum/electrumabc/bitcoin.py
335 ↗(On Diff #48104)

This is an indicator that this function is never called or never tested ?

This revision now requires changes to proceed.Jun 5 2024, 18:20
PiRK mentioned this in D16303: [electrum] add test coverage for base58 address encoding.Jun 6 2024, 09:49
PiRK updated this revision to Diff 48154.Jun 6 2024, 09:56

rebase after adding test coverage

PiRK edited the summary of this revision. (Show Details)Jun 6 2024, 09:56
PiRK added a parent revision: D16303: [electrum] add test coverage for base58 address encoding.
PiRK removed a parent revision: D16277: [electrum] move-only: split part of bitcoin.py into crypto.py.
Harbormaster completed remote builds in B29249: Diff 48154.Jun 6 2024, 10:17
Fabien accepted this revision.Jun 6 2024, 10:28
This revision is now accepted and ready to land.Jun 6 2024, 10:28
Closed by commit rABC0de5b333b9d5: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py (authored by PiRK). · Explain WhyJun 6 2024, 12:58
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in rABCad4b678ffef3: [electrum] add test coverage for base58 address encoding.
PiRK added a commit: rABC0de5b333b9d5: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py.
PiRK mentioned this in D16354: [electrum] remove broken PaymentRequestBitPay20.Jun 19 2024, 15:18
PiRK mentioned this in rABCd46492c45532: [electrum] remove broken PaymentRequestBitPay20.Jun 20 2024, 10:19

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
2 lines
avalanche/
3 lines
341 lines
7 lines
345 lines
6 lines
7 lines
2 lines
8 lines
tests/
147 lines
142 lines
2 lines
17 lines
7 lines
electrumabc_gui/
qt/
3 lines
2 lines
7 lines
electrumabc_plugins/
cosigner_pool/
5 lines
digitalbitbox/
14 lines
fusion/
2 lines
2 lines
2 lines
keepkey/
8 lines
ledger/
3 lines
satochip/
3 lines
trezor/
8 lines

Diff 48162

View Options

electrum/electrumabc/address.py

Loading...
View Options

electrum/electrumabc/avalanche/primitives.py

Loading...
View Options

electrum/electrumabc/bitcoin.py

Loading...
View Options

electrum/electrumabc/commands.py

Loading...
View Options

electrum/electrumabc/ecc.py

Loading...
View Options

electrum/electrumabc/keystore.py

Loading...
View Options

electrum/electrumabc/paymentrequest.py

Loading...
View Options

electrum/electrumabc/schnorr.py

Loading...
View Options

electrum/electrumabc/storage.py

Loading...
View Options

electrum/electrumabc/tests/test_bitcoin.py

Loading...
View Options

electrum/electrumabc/tests/test_ecc.py

Loading...
View Options

electrum/electrumabc/tests/test_schnorr.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc/wallet.py

Loading...
View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...
View Options

electrum/electrumabc_gui/qt/sign_verify_dialog.py

Loading...
View Options

electrum/electrumabc_gui/qt/update_checker.py

Loading...
View Options

electrum/electrumabc_plugins/cosigner_pool/qt.py

Loading...
View Options

electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/encrypt.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/fusion.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/pedersen.py

Loading...
View Options

electrum/electrumabc_plugins/keepkey/keepkey.py

Loading...
View Options

electrum/electrumabc_plugins/ledger/ledger.py

Loading...
View Options

electrum/electrumabc_plugins/satochip/satochip.py

Loading...
View Options

electrum/electrumabc_plugins/trezor/trezor.py

Loading...