Page MenuHomePhabricator

[electrum] move-only: extract more crypto code from bitcoin.py into ecc.py
ClosedPublic

Authored by PiRK on Jun 5 2024, 08:19.

Details

Summary

This is ecc.py move-only part of the original commit.

Inspired by https://github.com/spesmilo/electrum/commit/16e4827e8c6db833b0a969351b73eb34d489681f

Depends on D16303

Test Plan

python test_runner.py

Run the application, test basic features ./electrum-abc

Diff Detail

Event Timeline

PiRK requested review of this revision.Jun 5 2024, 08:19
Fabien requested changes to this revision.Jun 5 2024, 10:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/bitcoin.py
335 โ†—(On Diff #48104)

?

This revision now requires changes to proceed.Jun 5 2024, 10:02
electrum/electrumabc/bitcoin.py
335 โ†—(On Diff #48104)
	๐Ÿ˜ฌ
Fabien requested changes to this revision.Jun 5 2024, 18:20
Fabien added inline comments.
electrum/electrumabc/bitcoin.py
335 โ†—(On Diff #48104)

This is an indicator that this function is never called or never tested ?

This revision now requires changes to proceed.Jun 5 2024, 18:20

rebase after adding test coverage

This revision is now accepted and ready to land.Jun 6 2024, 10:28