Page MenuHomePhabricator
Differential D16301

[electrum] refactor ecc.py
AbandonedPublic
Actions

Authored by PiRK on Jun 6 2024, 08:55.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This improves the API slightly, and will make future electrum backports easier (I want to try electrum#8041)

https://github.com/spesmilo/electrum/commit/16e4827e8c6db833b0a969351b73eb34d489681f (refactoring ecc.py)
https://github.com/spesmilo/electrum/commit/4f9e4c520f29bfffd51738213bebfb514967e7ba

Depends on D16300

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
new_bitcoin_app
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29245
Build 58026: Build Diffelectrum-tests
Build 58025: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 6 2024, 08:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2024, 08:55
PiRK requested review of this revision.Jun 6 2024, 08:55
teamcity edited the summary of this revision. (Show Details)Jun 6 2024, 08:55
PiRK edited the summary of this revision. (Show Details)Jun 6 2024, 08:55
PiRK added a parent revision: D16300: [electrum] prefer int.from_bytes over int('0x'+hex, 16).
Harbormaster completed remote builds in B29245: Diff 48144.Jun 6 2024, 08:57
PiRK added a child revision: D16302: [electrum] minor cleanup in Transaction.verify_signature.Jun 6 2024, 09:10
PiRK planned changes to this revision.Jun 6 2024, 14:13
PiRK mentioned this in D16347: [electrum] cleanup ECC_YfromX.Jun 19 2024, 12:23
PiRK mentioned this in D16348: [electrum] cleanup ser_to_point.
PiRK mentioned this in D16349: [electrum] introduce a new ECPubkey class.Jun 19 2024, 12:28
PiRK mentioned this in D16350: [electrum] cleanup point_to_ser and stop leaking ecdsa implementation details for ECPubkey.
PiRK mentioned this in D16351: [electrum] use ECPubkey in verify_message.Jun 19 2024, 12:32
PiRK mentioned this in D16355: [electrum] move pubkey_from_signature -> ECPubkey.from_signature65.Jun 19 2024, 15:23
PiRK mentioned this in rABC83565a45b310: [electrum] cleanup ECC_YfromX.Jun 20 2024, 10:19
PiRK mentioned this in rABC1e5fc68f200a: [electrum] cleanup ser_to_point.
PiRK mentioned this in rABCa3595882e2a7: [electrum] introduce a new ECPubkey class.
PiRK mentioned this in rABC74b0434cd708: [electrum] cleanup point_to_ser and stop leaking ecdsa implementation details….
PiRK mentioned this in rABC398a5f60947e: [electrum] use ECPubkey in verify_message.
PiRK mentioned this in rABC2065f00accec: [electrum] move pubkey_from_signature -> ECPubkey.from_signature65.
PiRK mentioned this in D16676: [electrum] refactor private key class to better abstract ecdsa library usage.Aug 23 2024, 16:14
PiRK mentioned this in rABC26c62cc78b2c: [electrum] refactor private key class to better abstract ecdsa library usage.Sep 3 2024, 06:19
PiRK abandoned this revision.Fri, Oct 25, 19:20

done (split in multiple diffs)

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
6 lines
avalanche/
4 lines
28 lines
18 lines
17 lines
514 lines
6 lines
6 lines
16 lines
22 lines
tests/
4 lines
48 lines
4 lines
36 lines
4 lines
electrumabc_gui/
qt/
5 lines
6 lines
32 lines
electrumabc_plugins/
cosigner_pool/
11 lines
digitalbitbox/
41 lines
fusion/
21 lines
18 lines

Diff 48144

View Options

electrum/electrumabc/address.py

Loading...
View Options

electrum/electrumabc/avalanche/primitives.py

Loading...
View Options

electrum/electrumabc/bip32.py

Loading...
View Options

electrum/electrumabc/bitcoin.py

Loading...
View Options

electrum/electrumabc/commands.py

Loading...
View Options

electrum/electrumabc/ecc.py

Loading...
View Options

electrum/electrumabc/keystore.py

Loading...
View Options

electrum/electrumabc/paymentrequest.py

Loading...
View Options

electrum/electrumabc/schnorr.py

Loading...
View Options

electrum/electrumabc/storage.py

Loading...
View Options

electrum/electrumabc/tests/test_bitcoin.py

Loading...
View Options

electrum/electrumabc/tests/test_ecc.py

Loading...
View Options

electrum/electrumabc/tests/test_schnorr.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc/wallet.py

Loading...
View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...
View Options

electrum/electrumabc_gui/qt/sign_verify_dialog.py

Loading...
View Options

electrum/electrumabc_gui/qt/update_checker.py

Loading...
View Options

electrum/electrumabc_plugins/cosigner_pool/qt.py

Loading...
View Options

electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/encrypt.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/pedersen.py

Loading...