Page MenuHomePhabricator
Differential D16347

[electrum] cleanup ECC_YfromX
ClosedPublic
Actions

Authored by PiRK on Wed, Jun 19, 12:23.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC83565a45b310: [electrum] cleanup ECC_YfromX
Summary

Rename the function to get_y_coord_from_x, return only y (the offset is ignored in the only callsite), don't pass the curve as a parameter (we always use the same one).

This is split out for D16301

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Jun 19, 12:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jun 19, 12:23
PiRK requested review of this revision.Wed, Jun 19, 12:23
PiRK added a child revision: D16348: [electrum] cleanup ser_to_point.
Harbormaster completed remote builds in B29338: Diff 48295.Wed, Jun 19, 12:25
Fabien accepted this revision.Wed, Jun 19, 19:36
This revision is now accepted and ready to land.Wed, Jun 19, 19:36
Closed by commit rABC83565a45b310: [electrum] cleanup ECC_YfromX (authored by PiRK). · Explain WhyThu, Jun 20, 10:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC83565a45b310: [electrum] cleanup ECC_YfromX.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
18 lines

Diff 48323

View Options

electrum/electrumabc/ecc.py

Loading...