Paths

Table of Contentst

Differential D16350

[electrum] cleanup point_to_ser and stop leaking ecdsa implementation details for ECPubkey
ClosedPublic
Actions

Authored by PiRK on Wed, Jun 19, 12:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC74b0434cd708: [electrum] cleanup point_to_ser and stop leaking ecdsa implementation details…

Summary

Better variable names, support Tuple[int, int] as input

User of ECPubkey should not have to know anything about the ecdsa library, so ECPubkey.point() now returns an int 2-tuple and ECPubkey.from_point() accepts such a tuple.

Depends on D16349

This is split out of D16301

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Jun 19, 12:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jun 19, 12:29

PiRK requested review of this revision.Wed, Jun 19, 12:29

Harbormaster completed remote builds in B29341: Diff 48298.Wed, Jun 19, 12:31

PiRK added a child revision: D16351: [electrum] use ECPubkey in verify_message.Wed, Jun 19, 12:32

Fabien accepted this revision.Wed, Jun 19, 20:00

This revision is now accepted and ready to land.Wed, Jun 19, 20:00

rebase

Harbormaster completed remote builds in B29355: Diff 48317.Thu, Jun 20, 07:09

Closed by commit rABC74b0434cd708: [electrum] cleanup point_to_ser and stop leaking ecdsa implementation details… (authored by PiRK). · Explain WhyThu, Jun 20, 10:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC74b0434cd708: [electrum] cleanup point_to_ser and stop leaking ecdsa implementation details….

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

ecc.py

25 lines

schnorr.py

8 lines

transaction.py

6 lines

electrumabc_plugins/

fusion/

encrypt.py

6 lines

pedersen.py

12 lines

Diff 48326

View Options

electrum/electrumabc/ecc.py

View Options

electrum/electrumabc/schnorr.py

View Options

electrum/electrumabc/transaction.py

View Options

electrum/electrumabc_plugins/fusion/encrypt.py

View Options

electrum/electrumabc_plugins/fusion/pedersen.py

[electrum] cleanup point_to_ser and stop leaking ecdsa implementation details for ECPubkeyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48326

electrum/electrumabc/ecc.py

electrum/electrumabc/schnorr.py

electrum/electrumabc/transaction.py

electrum/electrumabc_plugins/fusion/encrypt.py

electrum/electrumabc_plugins/fusion/pedersen.py

[electrum] cleanup point_to_ser and stop leaking ecdsa implementation details for ECPubkey
ClosedPublic
Actions

Revision Contents
Changeset List