Page MenuHomePhabricator
Differential D16352

[electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address
ClosedPublic
Actions

Authored by PiRK on Wed, Jun 19, 12:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2f9c5287d613: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address
Summary

The ECKey class is about to be replaced. And we don't need a private key to verify a message anyway.

Depends on D16351

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Jun 19, 12:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jun 19, 12:35
PiRK requested review of this revision.Wed, Jun 19, 12:35
Harbormaster completed remote builds in B29343: Diff 48300.Wed, Jun 19, 12:38
PiRK added inline comments.Wed, Jun 19, 12:42
electrum/electrumabc/ecc.py
291 ↗(On Diff #48300)

similar change of behavior as D16351, we no longer raise errors from pubkey_from_signature on malformed signatures, we just return false. So sign_message below no longer needs to catch the error (and now actually checks the return value of verify_message)

PiRK added a child revision: D16354: [electrum] remove broken PaymentRequestBitPay20.Wed, Jun 19, 15:18
PiRK updated this revision to Diff 48319.Thu, Jun 20, 07:08

rebase

Harbormaster completed remote builds in B29357: Diff 48319.Thu, Jun 20, 07:11
Fabien accepted this revision.Thu, Jun 20, 07:58
This revision is now accepted and ready to land.Thu, Jun 20, 07:58
Closed by commit rABC2f9c5287d613: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address (authored by PiRK). · Explain WhyThu, Jun 20, 10:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2f9c5287d613: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
40 lines
tests/
5 lines

Diff 48328

View Options

electrum/electrumabc/ecc.py

Loading...
View Options

electrum/electrumabc/tests/test_ecc.py

Loading...