Page MenuHomePhabricator

[electrum] introduce a new ECPubkey class
ClosedPublic

Authored by PiRK on Jun 19 2024, 12:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa3595882e2a7: [electrum] introduce a new ECPubkey class
Summary

and start using it in transaction.py to verify tx signatures.
This makes the MyVerifyingKey private to ecc.py.

In a following diff, it will be used to verify other type of messages as well, and will serve as a base class for a ECPrivkey class that will replace the current ECKey class.
These new classes will encapsulate the interaction with the ecdsa lib, so that other modules don't need to know about this implementation detail.

Depends on D16348

This is split out of D16301

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Also future backports of electrum will depend on these changes (PSBT for instance)

Fabien requested changes to this revision.Jun 19 2024, 19:55
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/ecc.py
294 ↗(On Diff #48297)
This revision now requires changes to proceed.Jun 19 2024, 19:55
This revision is now accepted and ready to land.Jun 20 2024, 07:14
This revision was automatically updated to reflect the committed changes.