Page MenuHomePhabricator
Differential D16349

[electrum] introduce a new ECPubkey class
ClosedPublic
Actions

Authored by PiRK on Wed, Jun 19, 12:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa3595882e2a7: [electrum] introduce a new ECPubkey class
Summary

and start using it in transaction.py to verify tx signatures.
This makes the MyVerifyingKey private to ecc.py.

In a following diff, it will be used to verify other type of messages as well, and will serve as a base class for a ECPrivkey class that will replace the current ECKey class.
These new classes will encapsulate the interaction with the ecdsa lib, so that other modules don't need to know about this implementation detail.

Depends on D16348

This is split out of D16301

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Jun 19, 12:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jun 19, 12:28
PiRK requested review of this revision.Wed, Jun 19, 12:28
PiRK added a child revision: D16350: [electrum] cleanup point_to_ser and stop leaking ecdsa implementation details for ECPubkey.
PiRK added a comment.Wed, Jun 19, 12:30

Also future backports of electrum will depend on these changes (PSBT for instance)

Harbormaster completed remote builds in B29340: Diff 48297.Wed, Jun 19, 12:30
Fabien requested changes to this revision.Wed, Jun 19, 19:55
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/ecc.py
294 ↗(On Diff #48297)
This revision now requires changes to proceed.Wed, Jun 19, 19:55
PiRK updated this revision to Diff 48316.Thu, Jun 20, 07:06

fix f-string, rebase

Harbormaster completed remote builds in B29354: Diff 48316.Thu, Jun 20, 07:08
Fabien accepted this revision.Thu, Jun 20, 07:14
This revision is now accepted and ready to land.Thu, Jun 20, 07:14
Closed by commit rABCa3595882e2a7: [electrum] introduce a new ECPubkey class (authored by PiRK). · Explain WhyThu, Jun 20, 10:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa3595882e2a7: [electrum] introduce a new ECPubkey class.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
79 lines
11 lines
electrumabc_plugins/
digitalbitbox/
7 lines

Diff 48325

View Options

electrum/electrumabc/ecc.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py

Loading...