Paths

Table of Contentst

Differential D16352

[electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address
ClosedPublic
Actions

Authored by PiRK on Jun 19 2024, 12:35.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC2f9c5287d613: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address

Summary

The ECKey class is about to be replaced. And we don't need a private key to verify a message anyway.

Depends on D16351

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29343
Build 58222: Build Diff	electrum-tests
Build 58221: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 19 2024, 12:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2024, 12:35

PiRK requested review of this revision.Jun 19 2024, 12:35

Harbormaster completed remote builds in B29343: Diff 48300.Jun 19 2024, 12:38

PiRK added inline comments.Jun 19 2024, 12:42

electrum/electrumabc/ecc.py
291	similar change of behavior as D16351, we no longer raise errors from pubkey_from_signature on malformed signatures, we just return false. So `sign_message` below no longer needs to catch the error (and now actually checks the return value of verify_message)

PiRK added a child revision: D16354: [electrum] remove broken PaymentRequestBitPay20.Jun 19 2024, 15:18

rebase

Harbormaster completed remote builds in B29357: Diff 48319.Jun 20 2024, 07:11

Fabien accepted this revision.Jun 20 2024, 07:58

This revision is now accepted and ready to land.Jun 20 2024, 07:58

Closed by commit rABC2f9c5287d613: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address (authored by PiRK). · Explain WhyJun 20 2024, 10:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2f9c5287d613: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

40 lines

tests/

5 lines

Diff 48300

electrum/electrumabc/ecc.py

Loading...

electrum/electrumabc/tests/test_ecc.py

Loading...