Page MenuHomePhabricator

[electrum] add test coverage for base58 address encoding
ClosedPublic

Authored by PiRK on Jun 6 2024, 09:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCad4b678ffef3: [electrum] add test coverage for base58 address encoding
Summary

Review of D16278 revealed that there is not test coverage for hash160_to_p2sh

Add a test vector for this function and two adjacent functions.

Cleanup TestBitcoin._do_test_crypto: remove a to call to public_key_to_p2pkh whose return value was ignored. We add coverage in the new test for this function.

Depends on D16277

Test Plan

python -m electrumabc.tests.test_bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable