Paths

Table of Contentst

Differential D16277

[electrum] move-only: split part of bitcoin.py into crypto.py
ClosedPublic
Actions

Authored by PiRK on Jun 5 2024, 08:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6877d06fc660: [electrum] move-only: split part of bitcoin.py into crypto.py

Summary

The bitcoin.py module is huge and deals with a variety of unrelated things. This is a small step towards improving the situation.

Inspired by https://github.com/spesmilo/electrum/commit/16e4827e8c6db833b0a969351b73eb34d489681f

Test Plan

python test_runner.py

Run the application, do a few basic actions (send, receive txs) to check that core features are not broken

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 5 2024, 08:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2024, 08:16

PiRK requested review of this revision.Jun 5 2024, 08:16

PiRK added a child revision: D16278: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py.Jun 5 2024, 08:19

Harbormaster completed remote builds in B29216: Diff 48103.Jun 5 2024, 08:20

Fabien accepted this revision.Jun 5 2024, 09:58

This revision is now accepted and ready to land.Jun 5 2024, 09:58

PiRK added a child revision: D16303: [electrum] add test coverage for base58 address encoding.Jun 6 2024, 09:49

PiRK removed a child revision: D16278: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py.Jun 6 2024, 09:57

Closed by commit rABC6877d06fc660: [electrum] move-only: split part of bitcoin.py into crypto.py (authored by PiRK). · Explain WhyJun 6 2024, 12:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6877d06fc660: [electrum] move-only: split part of bitcoin.py into crypto.py.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

address.py

2 lines

avalanche/

2 lines

2 lines

131 lines

5 lines

3 lines

3 lines

159 lines

33 lines

3 lines

5 lines

tests/

39 lines

45 lines

19 lines

3 lines

3 lines

electrumabc_gui/

qt/

multi_transactions_dialog.py

2 lines

electrumabc_plugins/

cosigner_pool/

qt.py

3 lines

digitalbitbox/

digitalbitbox.py

10 lines

fusion/

util.py

3 lines

ledger/

ledger.py

3 lines

satochip/

satochip.py

9 lines

Diff 48160

View Options

electrum/electrumabc/address.py

View Options

electrum/electrumabc/avalanche/delegation.py

View Options

electrum/electrumabc/avalanche/proof.py

View Options

electrum/electrumabc/bitcoin.py

View Options

electrum/electrumabc/blockchain.py

View Options

electrum/electrumabc/coinchooser.py

View Options

electrum/electrumabc/commands.py

View Options

electrum/electrumabc/crypto.py

View Options

electrum/electrumabc/keystore.py

View Options

electrum/electrumabc/network.py

View Options

electrum/electrumabc/paymentrequest.py

View Options

electrum/electrumabc/tests/test_bitcoin.py

View Options

electrum/electrumabc/tests/test_crypto.py

View Options

electrum/electrumabc/transaction.py

View Options

electrum/electrumabc/verifier.py

View Options

electrum/electrumabc/wallet.py

View Options

electrum/electrumabc_gui/qt/multi_transactions_dialog.py

View Options

electrum/electrumabc_plugins/cosigner_pool/qt.py

View Options

electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py

View Options

electrum/electrumabc_plugins/fusion/util.py

View Options

electrum/electrumabc_plugins/ledger/ledger.py

View Options

electrum/electrumabc_plugins/satochip/satochip.py

[electrum] move-only: split part of bitcoin.py into crypto.pyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48160

electrum/electrumabc/address.py

electrum/electrumabc/avalanche/delegation.py

electrum/electrumabc/avalanche/proof.py

electrum/electrumabc/bitcoin.py

electrum/electrumabc/blockchain.py

electrum/electrumabc/coinchooser.py

electrum/electrumabc/commands.py

electrum/electrumabc/crypto.py

electrum/electrumabc/keystore.py

electrum/electrumabc/network.py

electrum/electrumabc/paymentrequest.py

electrum/electrumabc/tests/test_bitcoin.py

electrum/electrumabc/tests/test_crypto.py

electrum/electrumabc/transaction.py

electrum/electrumabc/verifier.py

electrum/electrumabc/wallet.py

electrum/electrumabc_gui/qt/multi_transactions_dialog.py

electrum/electrumabc_plugins/cosigner_pool/qt.py

electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py

electrum/electrumabc_plugins/fusion/util.py

electrum/electrumabc_plugins/ledger/ledger.py

electrum/electrumabc_plugins/satochip/satochip.py

[electrum] move-only: split part of bitcoin.py into crypto.py
ClosedPublic
Actions

Revision Contents
Changeset List