Paths

Table of Contentst

Differential D16279

[electrum] move-only: split bip32 from bitcoin.py
ClosedPublic
Actions

Authored by PiRK on Jun 5 2024, 08:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC346272c6adb7: [electrum] move-only: split bip32 from bitcoin.py

Summary

Backport of https://github.com/spesmilo/electrum/commit/a88a2dea8255532abdd20002c866b443237a509c

Also remove unused function xpub_from_pubkey

Depends on D16278

Test Plan

python test_runner.py

run the application from source, make sure the basic features are working

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 5 2024, 08:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2024, 08:22

PiRK requested review of this revision.Jun 5 2024, 08:22

PiRK edited the summary of this revision. (Show Details)Jun 5 2024, 08:23

Harbormaster completed remote builds in B29218: Diff 48105.Jun 5 2024, 08:25

Fabien accepted this revision.Jun 5 2024, 10:04

This revision is now accepted and ready to land.Jun 5 2024, 10:04

PiRK added a child revision: D16300: [electrum] prefer int.from_bytes over int('0x'+hex, 16).Jun 6 2024, 08:52

Closed by commit rABC346272c6adb7: [electrum] move-only: split bip32 from bitcoin.py (authored by PiRK). · Explain WhyJun 6 2024, 12:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC346272c6adb7: [electrum] move-only: split bip32 from bitcoin.py.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

5 lines

319 lines

291 lines

42 lines

5 lines

2 lines

tests/

test_bip32.py

113 lines

test_bitcoin.py

105 lines

wallet.py

5 lines

electrumabc_gui/

qt/

main_window.py

7 lines

electrumabc_plugins/

cosigner_pool/

qt.py

7 lines

keepkey/

clientbase.py

2 lines

keepkey.py

3 lines

qt.py

3 lines

ledger/

ledger.py

4 lines

satochip/

satochip.py

3 lines

trezor/

clientbase.py

2 lines

trezor.py

3 lines

Diff 48163

View Options

electrum/electrumabc/base_wizard.py

View Options

electrum/electrumabc/bip32.py

View Options

electrum/electrumabc/bitcoin.py

View Options

electrum/electrumabc/keystore.py

View Options

electrum/electrumabc/plugins.py

View Options

electrum/electrumabc/synchronizer.py

View Options

electrum/electrumabc/tests/test_bip32.py

View Options

electrum/electrumabc/tests/test_bitcoin.py

View Options

electrum/electrumabc/wallet.py

View Options

electrum/electrumabc_gui/qt/main_window.py

View Options

electrum/electrumabc_plugins/cosigner_pool/qt.py

View Options

electrum/electrumabc_plugins/keepkey/clientbase.py

View Options

electrum/electrumabc_plugins/keepkey/keepkey.py

View Options

electrum/electrumabc_plugins/keepkey/qt.py

View Options

electrum/electrumabc_plugins/ledger/ledger.py

View Options

electrum/electrumabc_plugins/satochip/satochip.py

View Options

electrum/electrumabc_plugins/trezor/clientbase.py

View Options

electrum/electrumabc_plugins/trezor/trezor.py

[electrum] move-only: split bip32 from bitcoin.pyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48163

electrum/electrumabc/base_wizard.py

electrum/electrumabc/bip32.py

electrum/electrumabc/bitcoin.py

electrum/electrumabc/keystore.py

electrum/electrumabc/plugins.py

electrum/electrumabc/synchronizer.py

electrum/electrumabc/tests/test_bip32.py

electrum/electrumabc/tests/test_bitcoin.py

electrum/electrumabc/wallet.py

electrum/electrumabc_gui/qt/main_window.py

electrum/electrumabc_plugins/cosigner_pool/qt.py

electrum/electrumabc_plugins/keepkey/clientbase.py

electrum/electrumabc_plugins/keepkey/keepkey.py

electrum/electrumabc_plugins/keepkey/qt.py

electrum/electrumabc_plugins/ledger/ledger.py

electrum/electrumabc_plugins/satochip/satochip.py

electrum/electrumabc_plugins/trezor/clientbase.py

electrum/electrumabc_plugins/trezor/trezor.py

[electrum] move-only: split bip32 from bitcoin.py
ClosedPublic
Actions

Revision Contents
Changeset List