Paths

Table of Contentst

Differential D10035

walletdb: track database file use as m_refcount within BerkeleyDatabase
ClosedPublic
Actions

Authored by PiRK on Sep 3 2021, 17:06.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC45210e0f0dc3: walletdb: track database file use as m_refcount within BerkeleyDatabase

Summary

Instead of having BerkeleyEnvironment track the file use count, make
BerkeleyDatabase do it itself.

This is a backport of core#19335 [2/5]
https://github.com/bitcoin/bitcoin/pull/19335/commits/4fe4b3bf1b152877677a6115f82aefaf318dd514

Depends on D10034

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16538
Build 32938: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 32937: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 3 2021, 17:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2021, 17:06

PiRK requested review of this revision.Sep 3 2021, 17:06

teamcity edited the summary of this revision. (Show Details)Sep 3 2021, 17:07

PiRK added a child revision: D10036: walletdb: Move Db->open to BerkeleyDatabase::Open.Sep 3 2021, 17:08

Harbormaster completed remote builds in B16538: Diff 29772.Sep 3 2021, 17:26

majcosta accepted this revision.Sep 3 2021, 18:10

This revision is now accepted and ready to land.Sep 3 2021, 18:10

Closed by commit rABC45210e0f0dc3: walletdb: track database file use as m_refcount within BerkeleyDatabase (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhySep 6 2021, 16:01

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC45210e0f0dc3: walletdb: track database file use as m_refcount within BerkeleyDatabase.

Unknown Object (User) added a subscriber: Unknown Object (User).Jul 12 2024, 08:36

This comment was removed by Fabien.

Fabien added a subscriber: Fabien.Jul 12 2024, 08:50

Revision Contents
Changeset List

Path

Size

src/

wallet/

bdb.h

1 line

bdb.cpp

57 lines

Diff 29772

View Options

src/wallet/bdb.h