Page MenuHomePhabricator
Differential D10123

lint all the python imports with isort
AbandonedPublic
Actions

Authored by PiRK on Sep 15 2021, 16:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

This is a commit to automatically sort all imports before adding a new linter that will enforce this new sorting.

The command used was (excluding contrib/):

isort --profile=black --line-length=79 .

The rationale for --profile=black is that this generate the same style of multiline imports that we already use: one import per line with trailing commas, use parentheses, ensure newline before comments.

Also, black is increasingly popular and we may want to use it instead of autopep8 some day in the future. So it is a good idea to stay compatible.

The rationale for --line-length=79 is that it is the standard for autopep8, and is more strict (hence compatible with) black which uses 88.

Test Plan
ninja all check-all check-functional-extended
arc lint --everything

Diff Detail

Event Timeline

PiRK created this revision.Sep 15 2021, 16:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 15 2021, 16:28
PiRK requested review of this revision.Sep 15 2021, 16:28
PiRK added a child revision: D10124: add a linter for python imports.Sep 15 2021, 16:32
PiRK edited the summary of this revision. (Show Details)Sep 15 2021, 16:34
PiRK edited the test plan for this revision. (Show Details)Sep 15 2021, 16:42
Harbormaster completed remote builds in B16660: Diff 29976.Sep 15 2021, 16:44
Fabien requested changes to this revision.Sep 15 2021, 19:30
Fabien added a subscriber: Fabien.

This is way too big to be reviewed, please split

This revision now requires changes to proceed.Sep 15 2021, 19:30
PiRK planned changes to this revision.Sep 16 2021, 08:53

it needs splitting, and I'm still investigating whether it is possible to preserve the multiline imports that we already have, even if they would be shorter than 80 characters on a single line.

PiRK abandoned this revision.Sep 27 2021, 09:00

Split into multiple diffs: D10200 - D10206

PiRK added a child revision: D10229: wallet: Remove path checking code from loadwallet RPC.Sep 30 2021, 13:42

Large Diff

This large diff affects 141 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
cmake/
utils/
4 lines
share/
qt/
2 lines
rpcauth/
3 lines
src/
test/
data/
2 lines
test/
functional/
6 lines
7 lines
6 lines
3 lines
10 lines
6 lines
2 lines
6 lines
7 lines
12 lines
1 line
15 lines
14 lines
8 lines
20 lines
12 lines
15 lines
14 lines
19 lines
4 lines
2 lines
4 lines
2 lines
4 lines
17 lines
2 lines
data/
22 lines
20 lines
5 lines
4 lines
5 lines
7 lines
5 lines
17 lines
4 lines
5 lines
6 lines
6 lines
6 lines
2 lines
1 line
3 lines
1 line
9 lines
1 line
9 lines
15 lines
2 lines
2 lines
2 lines
2 lines
6 lines
2 lines
15 lines
2 lines
1 line
13 lines
6 lines
2 lines
26 lines
14 lines
5 lines
2 lines
4 lines
12 lines
5 lines
17 lines
17 lines
19 lines
5 lines
6 lines
7 lines
11 lines
7 lines
13 lines
7 lines
9 lines
12 lines
5 lines
2 lines
6 lines
5 lines
5 lines
7 lines
5 lines
7 lines
4 lines
6 lines
5 lines
8 lines
5 lines
2 lines
4 lines
5 lines
2 lines
8 lines
11 lines
test_framework/
2 lines
2 lines
16 lines
26 lines
1 line
8 lines
5 lines
18 lines
3 lines
8 lines
10 lines
2 lines
10 lines
8 lines
18 lines
7 lines
4 lines
6 lines
2 lines
4 lines
9 lines
5 lines
5 lines
5 lines
2 lines
7 lines
2 lines
9 lines
3 lines
7 lines
13 lines
5 lines
5 lines
4 lines
8 lines
9 lines
5 lines
fuzz/
2 lines
lint/
4 lines
2 lines

Diff 29976

View Options

cmake/utils/gen-ninja-deps.py

View Options

share/qt/extract_strings_qt.py

View Options

share/rpcauth/rpcauth.py

View Options

src/test/data/generate_asmap.py

View Options

test/functional/abc-get-invalid-block.py

View Options

test/functional/abc-invalid-chains.py

View Options

test/functional/abc-invalid-message.py

View Options

test/functional/abc-mempool-coherence-on-activations.py

View Options

test/functional/abc-minimaldata.py

View Options

test/functional/abc-parkedchain.py

View Options

test/functional/abc-replay-protection.py

View Options

test/functional/abc-schnorr.py

View Options

test/functional/abc-schnorrmultisig.py

View Options

test/functional/abc-segwit-recovery.py

View Options

test/functional/abc-sync-chain.py

View Options

test/functional/abc-transaction-ordering.py

View Options

test/functional/abc_feature_minerfund.py

View Options

test/functional/abc_mining_basic.py

View Options

test/functional/abc_p2p_avalanche_peer_discovery.py

View Options

test/functional/abc_p2p_avalanche_voting.py

View Options

test/functional/abc_p2p_compactblocks.py

View Options

test/functional/abc_p2p_fullblocktest.py

View Options

test/functional/abc_p2p_proof_inventory.py

View Options

test/functional/abc_rpc_addavalanchenode.py

View Options

test/functional/abc_rpc_avalancheproof.py

View Options

test/functional/abc_rpc_buildavalancheproof.py

View Options

test/functional/abc_rpc_getavalanchepeerinfo.py

View Options

test/functional/abc_wallet_dumpcoins.py

View Options

test/functional/abc_wallet_standardness.py

View Options

test/functional/combine_logs.py

View Options

test/functional/data/invalid_txs.py

View Options

test/functional/example_test.py

View Options

test/functional/feature_abortnode.py

View Options

test/functional/feature_assumevalid.py

View Options

test/functional/feature_bip68_sequence.py

View Options

test/functional/feature_block.py

View Options

test/functional/feature_blocksdir.py

View Options

test/functional/feature_cltv.py

View Options

test/functional/feature_csv_activation.py

View Options

test/functional/feature_dbcrash.py

View Options

test/functional/feature_dersig.py

View Options

test/functional/feature_maxuploadtarget.py

View Options

test/functional/feature_proxy.py

View Options

test/functional/feature_pruning.py

View Options

test/functional/feature_settings.py

View Options

test/functional/feature_shutdown.py

View Options

test/functional/interface_bitcoin_cli.py

View Options

test/functional/interface_rest.py

View Options

test/functional/interface_rpc.py

View Options

test/functional/interface_zmq.py

View Options

test/functional/mempool_accept.py

View Options

test/functional/mempool_persist.py

View Options

test/functional/mempool_reorg.py

View Options

test/functional/mempool_resurrect.py

View Options

test/functional/mempool_spend_coinbase.py

View Options

test/functional/mempool_unbroadcast.py

View Options

test/functional/mempool_updatefromblock.py

View Options

test/functional/mining_basic.py

View Options

test/functional/mining_getblocktemplate_longpoll.py

View Options

test/functional/mining_prioritisetransaction.py

View Options

test/functional/p2p_addr_relay.py

View Options

test/functional/p2p_addrv2_relay.py

View Options

test/functional/p2p_blocksonly.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/p2p_dos_header_tree.py

View Options

test/functional/p2p_feefilter.py

View Options

test/functional/p2p_filter.py

View Options

test/functional/p2p_fingerprint.py

View Options

test/functional/p2p_getaddr_caching.py

View Options

test/functional/p2p_getdata.py

View Options

test/functional/p2p_inv_download.py

View Options

test/functional/p2p_invalid_messages.py

View Options

test/functional/p2p_invalid_tx.py

View Options

test/functional/p2p_leak.py

View Options

test/functional/p2p_leak_tx.py

View Options

test/functional/p2p_nobloomfilter_messages.py

View Options

test/functional/p2p_node_network_limited.py

View Options

test/functional/p2p_permissions.py

View Options

test/functional/p2p_sendheaders.py

View Options

test/functional/p2p_unrequested_blocks.py

View Options

test/functional/rpc_bind.py

View Options

test/functional/rpc_blockchain.py

View Options

test/functional/rpc_createmultisig.py

View Options

test/functional/rpc_deriveaddresses.py

View Options

test/functional/rpc_dumptxoutset.py

View Options

test/functional/rpc_generate.py

View Options

test/functional/rpc_generateblock.py

View Options

test/functional/rpc_getblockfilter.py

View Options

test/functional/rpc_getblockstats.py

View Options

test/functional/rpc_getdescriptorinfo.py

View Options

test/functional/rpc_help.py

View Options

test/functional/rpc_invalidateblock.py

View Options

test/functional/rpc_misc.py

View Options

test/functional/rpc_net.py

View Options

test/functional/rpc_preciousblock.py

View Options

test/functional/rpc_psbt.py

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/rpc_setban.py

View Options

test/functional/rpc_txoutproof.py

View Options

test/functional/rpc_users.py

View Options

test/functional/rpc_whitelist.py

View Options

test/functional/test_framework/address.py

View Options

test/functional/test_framework/authproxy.py

View Options

test/functional/test_framework/avatools.py

View Options

test/functional/test_framework/blocktools.py

View Options

test/functional/test_framework/coverage.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/netutil.py

View Options

test/functional/test_framework/p2p.py

View Options

test/functional/test_framework/script.py

View Options

test/functional/test_framework/test_framework.py

View Options

test/functional/test_framework/test_node.py

View Options

test/functional/test_framework/txtools.py

View Options

test/functional/test_framework/util.py

View Options

test/functional/test_framework/wallet_util.py

View Options

test/functional/test_runner.py

View Options

test/functional/wallet_address_types.py

View Options

test/functional/wallet_backup.py

View Options

test/functional/wallet_balance.py

View Options

test/functional/wallet_basic.py

View Options

test/functional/wallet_coinbase_category.py

View Options

test/functional/wallet_create_tx.py

View Options

test/functional/wallet_createwallet.py

View Options

test/functional/wallet_descriptor.py

View Options

test/functional/wallet_dump.py

View Options

test/functional/wallet_encryption.py

View Options

test/functional/wallet_groups.py

View Options

test/functional/wallet_hd.py

View Options

test/functional/wallet_import_rescan.py

View Options

test/functional/wallet_import_with_label.py

View Options

test/functional/wallet_importdescriptors.py

View Options

test/functional/wallet_importmulti.py

View Options

test/functional/wallet_keypool_topup.py

View Options

test/functional/wallet_listtransactions.py

View Options

test/functional/wallet_multiwallet.py

View Options

test/functional/wallet_reorgsrestore.py

View Options

test/functional/wallet_txn_clone.py

View Options

test/functional/wallet_watchonly.py

View Options

test/fuzz/test_runner.py

View Options

test/lint/check-doc.py

View Options

test/lint/check-rpc-mappings.py