Page MenuHomePhabricator
Differential D10149

Make all CRPCCommand actors take a const Config &
ClosedPublic
Actions

Authored by PiRK on Sep 17 2021, 15:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC634fcc0ea184: Make all CRPCCommand actors take a const Config &
Summary

After D9745 there seems to no longer be a need for RPC commands that
take a non-const Config as a parameter.
In D10007 and D10010, it seemed that the help RPC still needed a
non-const Config &, but it was actually no longer the case.
The help executes the other RPCs to get their help message, and since
D9745 removed setexcessiveblock, this is no longer needed.

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Sep 17 2021, 15:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2021, 15:07
PiRK requested review of this revision.Sep 17 2021, 15:07
PiRK mentioned this in D10146: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining).Sep 17 2021, 15:08
PiRK mentioned this in D10147: rpc: Assert that RPCArg names are equal to CRPCCommand ones (zmq).
PiRK mentioned this in D10148: rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump).
Harbormaster completed remote builds in B16695: Diff 30030.Sep 17 2021, 15:21
PiRK mentioned this in D10145: rpc: Remove unused return type from appendCommand.Sep 17 2021, 15:48
PiRK added a child revision: D10146: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining).
PiRK added a child revision: D10147: rpc: Assert that RPCArg names are equal to CRPCCommand ones (zmq).Sep 17 2021, 15:51
PiRK added a child revision: D10148: rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump).Sep 17 2021, 15:53
Fabien accepted this revision.Sep 19 2021, 05:12
This revision is now accepted and ready to land.Sep 19 2021, 05:12
Closed by commit rABC634fcc0ea184: Make all CRPCCommand actors take a const Config & (authored by PiRK). · Explain WhySep 19 2021, 07:51
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC634fcc0ea184: Make all CRPCCommand actors take a const Config &.

Revision Contents
Changeset List

PathSize
src/
interfaces/
2 lines
2 lines
rpc/
26 lines
30 lines
22 lines
5 lines

Diff 30030

View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/rpc/util.h

Loading...