Page MenuHomePhabricator
Differential D1016

optim: mark a few classes final
ClosedPublic
Actions

Authored by matiu on Jan 22 2018, 22:48.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T171: Backport core PR 10809: optim: mark a few classes final
Commits
rSTAGING93410ea50399: optim: mark a few classes final
rABC93410ea50399: optim: mark a few classes final
Summary

Enable devirtualization opportunities by using the final specifier (C++11)

  • Declaring CCoinsViewErrorCatcher final enables devirtualization of two calls
  • Declaring CReserveKey final enables devirtualization of one call

Core PR10809

Fixes T171

Test Plan

make check && test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10809
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1737
Build 1737: arc lint + arc unit

Event Timeline

matiu created this revision.Jan 22 2018, 22:48
Harbormaster completed remote builds in B1728: Diff 2684.Jan 22 2018, 22:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2018, 22:48
Herald added a reviewer: Restricted Project. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 22 2018, 22:48

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

matiu updated this revision to Diff 2685.Jan 22 2018, 22:51

Remove comment

teamcity added a comment.Jan 22 2018, 22:53

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 22 2018, 23:07

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Jan 22 2018, 23:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix requested changes to this revision.Jan 23 2018, 00:05

Can you fix the formatting ? We are using clang-format-4.0 .

This revision now requires changes to proceed.Jan 23 2018, 00:05
matiu added a comment.Jan 23 2018, 12:44

It's taking me a little more than expected to install clang-format-4.0 on macos... will update this as soon as I finish.

matiu updated this revision to Diff 2698.Jan 23 2018, 13:53

update lint

Harbormaster completed remote builds in B1737: Diff 2698.Jan 23 2018, 13:53
matiu added a comment.Jan 23 2018, 13:55

udpated!

teamcity added a comment.Jan 23 2018, 13:56

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 23 2018, 14:17

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix accepted this revision.Jan 23 2018, 21:43
This revision is now accepted and ready to land.Jan 23 2018, 21:43
Closed by commit rABC93410ea50399: optim: mark a few classes final (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by matiu). · Explain WhyJan 23 2018, 21:48
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
2 lines
wallet/
4 lines
zmq/
2 lines

Diff 2698

View Options

src/httpserver.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/zmq/zmqnotificationinterface.h

Loading...