Page MenuHomePhabricator

optim: mark a few classes final
ClosedPublic

Authored by matiu on Jan 22 2018, 22:48.

Details

Summary

Enable devirtualization opportunities by using the final specifier (C++11)

  • Declaring CCoinsViewErrorCatcher final enables devirtualization of two calls
  • Declaring CReserveKey final enables devirtualization of one call

Core PR10809

Fixes T171

Test Plan

make check && test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10809
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1737
Build 1737: arc lint + arc unit

Event Timeline

Herald added a reviewer: Restricted Project. · View Herald Transcript
deadalnix requested changes to this revision.Jan 23 2018, 00:05

Can you fix the formatting ? We are using clang-format-4.0 .

This revision now requires changes to proceed.Jan 23 2018, 00:05

It's taking me a little more than expected to install clang-format-4.0 on macos... will update this as soon as I finish.

This revision is now accepted and ready to land.Jan 23 2018, 21:43
This revision was automatically updated to reflect the committed changes.