Page MenuHomePhabricator
Differential D10206

sort python imports in remaining test_framework and misc files
ClosedPublic
Actions

Authored by PiRK on Sep 27 2021, 08:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf5ff0c42de56: sort python imports in remaining test_framework and misc files
Summary

This is preparation work to add a new linter that will enforce this new sorting.

The command used was:
isort --profile=black --line-length=79 src/ test/ cmake/ share/

See D10200 for the rationale regarding --profile=black --line-length=79

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 27 2021, 08:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2021, 08:56
PiRK requested review of this revision.Sep 27 2021, 08:57
PiRK added a child revision: D10124: add a linter for python imports.Sep 27 2021, 08:59
PiRK mentioned this in D10123: lint all the python imports with isort.Sep 27 2021, 09:00
Harbormaster completed remote builds in B16791: Diff 30174.Sep 27 2021, 09:38
Fabien added a subscriber: Fabien.Sep 28 2021, 18:08
Fabien added inline comments.
test/functional/test_framework/coverage.py
13 ↗(On Diff #30174)

Is that an isort thing ? Same as https://reviews.bitcoinabc.org/D10200

test/functional/test_framework/script.py
25 ↗(On Diff #30174)

Dito

PiRK added inline comments.Sep 29 2021, 07:15
test/functional/test_framework/coverage.py
13 ↗(On Diff #30174)

Yes. I added a note for this behavior in the description for D10200

Fabien accepted this revision.Sep 29 2021, 08:04
This revision is now accepted and ready to land.Sep 29 2021, 08:04
Closed by commit rABCf5ff0c42de56: sort python imports in remaining test_framework and misc files (authored by PiRK). · Explain WhySep 29 2021, 15:49
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf5ff0c42de56: sort python imports in remaining test_framework and misc files.

Revision Contents
Changeset List

PathSize
cmake/
utils/
4 lines
share/
qt/
2 lines
rpcauth/
3 lines
src/
test/
data/
2 lines
test/
functional/
2 lines
data/
22 lines
19 lines
test_framework/
2 lines
2 lines
16 lines
26 lines
1 line
8 lines
5 lines
18 lines
3 lines
8 lines
10 lines
2 lines
10 lines
8 lines
18 lines
fuzz/
2 lines
lint/
4 lines
2 lines

Diff 30211

View Options

cmake/utils/gen-ninja-deps.py

Loading...
View Options

share/qt/extract_strings_qt.py

Loading...
View Options

share/rpcauth/rpcauth.py

Loading...
View Options

src/test/data/generate_asmap.py

Loading...
View Options

test/functional/combine_logs.py

Loading...
View Options

test/functional/data/invalid_txs.py

Loading...
View Options

test/functional/example_test.py

Loading...
View Options

test/functional/test_framework/address.py

Loading...
View Options

test/functional/test_framework/authproxy.py

Loading...
View Options

test/functional/test_framework/avatools.py

Loading...
View Options

test/functional/test_framework/blocktools.py

Loading...
View Options

test/functional/test_framework/coverage.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...
View Options

test/functional/test_framework/netutil.py

Loading...
View Options

test/functional/test_framework/p2p.py

Loading...
View Options

test/functional/test_framework/script.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/txtools.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...
View Options

test/functional/test_framework/wallet_util.py

Loading...
View Options

test/functional/test_runner.py

Loading...
View Options

test/fuzz/test_runner.py

Loading...
View Options

test/lint/check-doc.py

Loading...
View Options

test/lint/check-rpc-mappings.py

Loading...