Remove Consensus::Params parameter from ContextualCheckBlock
ClosedPublic
Actions

Authored by matiu on Jan 23 2018, 21:03.

Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

T187: Remove Consensus::Params parameter from ContextualCheckBlock

Commits

rSTAGING6ef41ed3a922: Remove Consensus::Params parameter from ContextualCheckBlock
rABC6ef41ed3a922: Remove Consensus::Params parameter from ContextualCheckBlock

Summary

Remove Consensus::Params parameter from ContextualCheckBlock
since it can be accessed from the config and is therefore redundant.

Solves T187

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

t187

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1747
Build 1747: arc lint + arc unit

Event Timeline

matiu created this revision.Jan 23 2018, 21:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2018, 21:03

matiu edited the summary of this revision. (Show Details)Jan 23 2018, 21:04

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

jasonbcox accepted this revision.Jan 23 2018, 21:33

This revision is now accepted and ready to land.Jan 23 2018, 21:33

deadalnix accepted this revision.Jan 23 2018, 21:33

jasonbcox mentioned this in D1010: Remove redundant CChainParams from ConnectBlock.Jan 23 2018, 21:41

Closed by commit rABC6ef41ed3a922: Remove Consensus::Params parameter from ContextualCheckBlock (authored by matiu). · Explain WhyJan 23 2018, 21:47

This revision was automatically updated to reflect the committed changes.

matiu mentioned this in T187: Remove Consensus::Params parameter from ContextualCheckBlock.Jan 24 2018, 02:32

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

11 lines

Diff 2712

View Options

Remove Consensus::Params parameter from ContextualCheckBlockClosedPublicActions