Page MenuHomePhabricator
Differential D1051

Remove vchDefaultKey and have better first run detection
ClosedPublic
Actions

Authored by deadalnix on Jan 30 2018, 21:32.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING86c61268e769: Remove vchDefaultKey and have better first run detection
rABC86c61268e769: Remove vchDefaultKey and have better first run detection
Summary

Removes vchDefaultKey which was only used for first run detection.
Improves wallet first run detection by checking to see if any keys
were read from the database.

This will now also check for a valid defaultkey for backwards
compatibility reasons and to check for any corruption.

Keys will stil be generated on the first one, but there won't be
any shown in the address book as was previously done.

Backport core's PR10952

Depends on D1049

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
vchDefaultKeyremove
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1776
Build 1776: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 30 2018, 21:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2018, 21:32
Harbormaster completed remote builds in B1776: Diff 2764.Jan 30 2018, 21:32
deadalnix edited the summary of this revision. (Show Details)Jan 30 2018, 21:32
deadalnix added a parent revision: D1049: [wallet] Basic keypool topup.
deadalnix removed a parent revision: D1048: [wallet] Remove redundant initialization.
teamcity added a subscriber: teamcity.Jan 30 2018, 21:34

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 30 2018, 21:51

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel accepted this revision.Jan 31 2018, 22:53
This revision is now accepted and ready to land.Jan 31 2018, 22:53
Closed by commit rABC86c61268e769: Remove vchDefaultKey and have better first run detection (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyFeb 1 2018, 00:41
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.Oct 4 2019, 21:35

Revision Contents
Changeset List

PathSize
src/
wallet/
3 lines
4 lines
30 lines
2 lines
17 lines
test/
functional/
2 lines
4 lines

Diff 2764

View Options

src/wallet/crypter.h

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...
View Options

test/functional/keypool-topup.py

Loading...
View Options

test/functional/wallet-hd.py

Loading...