Page MenuHomePhabricator

Remove vchDefaultKey and have better first run detection
ClosedPublic

Authored by deadalnix on Jan 30 2018, 21:32.

Details

Summary

Removes vchDefaultKey which was only used for first run detection.
Improves wallet first run detection by checking to see if any keys
were read from the database.

This will now also check for a valid defaultkey for backwards
compatibility reasons and to check for any corruption.

Keys will stil be generated on the first one, but there won't be
any shown in the address book as was previously done.

Backport core's PR10952

Depends on D1049

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
vchDefaultKeyremove
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1776
Build 1776: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 31 2018, 22:53
This revision was automatically updated to reflect the committed changes.