Paths

Table of Contentst

Differential D10568

Use SQLite for descriptor wallets
AbandonedPublic
Actions

Authored by PiRK on Nov 26 2021, 15:03.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Summary

Commit https://github.com/bitcoin/bitcoin/pull/19077/commits/9af5de3798c49f86f27bb79396e075fb8c1b2381

Use SQLite for descriptor wallets

MakeWalletDatabase no longer has a default DatabaseFormat. Instead
callers, like CWallet::Create, need to specify the database type to
create if the file does not exist. If it exists and NONE is given, then
CreateWalletDatabase will try to autodetect the type.

Commit https://github.com/bitcoin/bitcoin/pull/19077/commits/9b78f3ce8ed1867c37f6b9fff98f74582d44b789

walletutil: Wallets can also be sqlite

Detect and open sqlite wallets

This is a backport of core#19077 [23 & 24/26]
It also includes a change to wallet_descriptor.py from core#20125 and a change from core#20365 to tool_wallet.py, because the commits activation --descriptors for these two functional tests were intentionaly backported out of order to improve the sqlite test coverage.

Depends on D10573

Test Plan

ninja all check-all

The SQLite wallets are now tested in various functional tests supporting the --descriptors option.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17686
Build 35198: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35197: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 26 2021, 15:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2021, 15:03

PiRK requested review of this revision.Nov 26 2021, 15:03

teamcity edited the summary of this revision. (Show Details)Nov 26 2021, 15:04

PiRK added a child revision: D10569: Use disk magic as sqlite wallet application ID.Nov 26 2021, 15:07

Harbormaster completed remote builds in B17405: Diff 31091.Nov 26 2021, 15:53

So the goal here is to create wallet, using sqllite, with zero test by default?

Is that a joke?

This revision now requires changes to proceed.Nov 26 2021, 16:47

PiRK mentioned this in D10569: Use disk magic as sqlite wallet application ID.Dec 1 2021, 08:43

PiRK mentioned this in D10567: walletutil: Wallets can also be sqlite.Dec 1 2021, 09:17

Squash with D10567, so that creating and opening sqlite descriptor wallets happens in the same commit, and is immediately coverd by functional tests.

Update the summary, dependency and test plan.

PiRK added a child revision: D10572: doc: Update wallet files in files.md.Dec 1 2021, 09:44

Harbormaster completed remote builds in B17477: Diff 31194.Dec 1 2021, 09:51

There is still a problem with the dependency cycle in phabricator that I need to solve. This now depends on D10571

PiRK removed a child revision: D10569: Use disk magic as sqlite wallet application ID.Dec 1 2021, 10:12

PiRK edited parent revisions, added: D10571: wallet: Enforce sqlite serialized threading mode; removed: D10567: walletutil: Wallets can also be sqlite.

manually fixed the dependency stack via the the phabricator interface

Where is this tested?

This revision now requires changes to proceed.Dec 14 2021, 17:01

PiRK mentioned this in D10576: rpc, wallet: Expose database format in getwalletinfo.Dec 15 2021, 16:38

Rebase on D10576 to have at least one test be explicitely affected by the database switch. Update wallet_descriptor.py accordingly, to check the database format for descriptor wallets is now "sqlite".

Under the hood, all functional tests running with --descriptors (see list in test_runner.py) will test sqlite operations from this point forward.

PiRK removed a parent revision: D10571: wallet: Enforce sqlite serialized threading mode.Dec 15 2021, 16:51

Harbormaster completed remote builds in B17653: Diff 31429.Dec 15 2021, 17:04

Fabien mentioned this in D10573: Run dumpwallet for legacy wallets only in wallet_backup.py.Dec 20 2021, 08:50

Rebase and include a necessary change from core#20365 to tool_wallet.py (because the test was intentionaly enabled for descriptor wallet in D10672 to improve sqlite test coverage on activation)

Update commit sequence number after moving D10573 before this commit (for additional sqlite test coverage).

Harbormaster completed remote builds in B17686: Diff 31474.Dec 20 2021, 14:58

Clearing my queue.

This revision now requires changes to proceed.Dec 20 2021, 15:59

PiRK removed a parent revision: D10576: rpc, wallet: Expose database format in getwalletinfo.Dec 20 2021, 17:14

Clearing my queue