Fix resendwallettransactions assert failure if -walletbroadcast=0
ClosedPublic
Actions

Authored by deadalnix on Feb 2 2018, 17:07.

Details

Reviewers

matiu
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING9dde477ad8ee: Fix resendwallettransactions assert failure if -walletbroadcast=0
rABC9dde477ad8ee: Fix resendwallettransactions assert failure if -walletbroadcast=0

Summary

Backport core's PR11002 and PR10995

Test Plan

make check
Run the resendwallettransactions test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fixwalletassert

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1795
Build 1795: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 2 2018, 17:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2018, 17:07

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

matiu accepted this revision.Feb 2 2018, 17:31

This revision is now accepted and ready to land.Feb 2 2018, 17:31

schancel accepted this revision.Feb 2 2018, 17:34

Closed by commit rABC9dde477ad8ee: Fix resendwallettransactions assert failure if -walletbroadcast=0 (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyFeb 2 2018, 18:21

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

7 lines

wallet.h

3 lines

wallet.cpp

1 line

Diff 2798

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/wallet.h

View Options

Fix resendwallettransactions assert failure if -walletbroadcast=0ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2798

src/wallet/rpcwallet.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

Fix resendwallettransactions assert failure if -walletbroadcast=0
ClosedPublic
Actions

Revision Contents
Changeset List