validation: Use *this in CChainState::ActivateBestChainStep
ClosedPublic
Actions

Authored by PiRK on Mar 18 2022, 08:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC915290d4f15a: validation: Use *this in CChainState::ActivateBestChainStep

Summary

This is a backport of core#21055 [12/16]
https://github.com/bitcoin/bitcoin/pull/21055/commits/a9d28bcd8d8f71d089322b1d631390352e31ee2b

Depends on D11216

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18556
Build 36907: Build Diff	build-clang-tidy · lint-circular-dependencies · build-clang · build-diff · build-debug · build-without-wallet
Build 36906: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 18 2022, 08:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2022, 08:33

PiRK requested review of this revision.Mar 18 2022, 08:33

teamcity edited the summary of this revision. (Show Details)Mar 18 2022, 08:34

PiRK added a child revision: D11220: validation: Pass in chain to FindBlockPos+SaveBlockToDisk.Mar 18 2022, 08:35

Harbormaster completed remote builds in B18556: Diff 32824.Mar 18 2022, 08:47

Fabien accepted this revision.Mar 18 2022, 09:27

This revision is now accepted and ready to land.Mar 18 2022, 09:27

Closed by commit rABC915290d4f15a: validation: Use *this in CChainState::ActivateBestChainStep (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 18 2022, 09:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC915290d4f15a: validation: Use *this in CChainState::ActivateBestChainStep.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

12 lines

Diff 32824

View Options

validation: Use *this in CChainState::ActivateBestChainStepClosedPublicActions